Hardware team - Add SensePi Code Coverage - Githubissues

gcivil-nyu-org / spring2020-cs-gy-9223-class

2 stars 14 forks source link

Hardware team - Add SensePi Code Coverage #585

Closed ab7289 closed 4 years ago

ab7289 commented 4 years ago

Description

This PR adds unit tests for the sense_pi.py file and also adds some coverage to some missing lines in other files.

Types of Changes

Put an x in the boxes that apply

[ ] Feature (non-breaking change which adds functionality)
[ ] Bug Fix (non-breaking change that fixes an issue)
[ ] Breaking Change (feature/fix that causes existing features to not work as expected)
[ ] Documentation
[x] Testing

Checklist

[ x] I have read the [contribute]contributing doc
[ x] Classes, scripts, and environment variables follow existing naming convention
[ x] Lint and Unit tests pass locally
[ x] New features on hardware have been tested on a local Raspberry Pi
[ x] Mention new programs/binaries if any must be installed along with this change
[ x] Mention new environment variables if any have been added to hardware/env file
[ x] Test coverage should not drop more than 3%

This PR closes #409

VentusXu09 commented 4 years ago

@ab7289 I think on-call members for this sprint is Tianrun and Sunny. Ziheng and I also missed this point for the last pull request. Please assign reviewers to the right on-call members.