gcivil-nyu-org / spring2020-cs-gy-9223-class

2 stars 14 forks source link

Adding error recording when no active event in pipeline #612

Closed Ricardo-1894 closed 4 years ago

Ricardo-1894 commented 4 years ago

Description

This PR:

  1. Adding error recording when no active event to pipeline
  2. Adding test
  3. Related to issue #446

Types of Changes

Put an x in the boxes that apply

Checklist

jackxujh commented 4 years ago

It seems the PR currently handles the situation when there is not active event. It may be better if the title and description reflect that. Because otherwise, people might expect it to handle situations like, the sensor is not valid, etc.

Ricardo-1894 commented 4 years ago

It seems the PR currently handles the situation when there is not active event. It may be better if the title and description reflect that. Because otherwise, people might expect it to handle situations like, the sensor is not valid, etc.

Good point, I have updated the description