Closed gcivil-nyu closed 4 years ago
@Ziheng-Wang I think this is a point professor made in class. The suggested change in this branch has already been integrated in the master branch via #632. You should be able to see it in the repo. My personal idea is not to merge this pull request, but rather, point out the proposed changes has been merged with #632, and close this PR.
@gcivil-nyu professor, thanks for pointing out the flaw in the contributing workflow. We have put a fix on that issue with pull request #632, and are now closing this pull request. For further discussion, we can continue on the new repo once it had been set up.
Title
Give a self-explanatory title
Description
If this fixes a bug or resolves an issue, provide a link to that issue. Give a detailed description that answers:
Types of Changes
Put an
x
in the boxes that applyChecklist