Hardware team - Githubissues

yashasvid commented 4 years ago

Title

Added get_speed_mph() function and relevant tests to get speed from gps hat.

The purpose of this PR is to add a small enhancement of getting speed from gps hat and adding tests for it.

Put an x in the boxes that apply

[x] Feature (non-breaking change which adds functionality)
[ ] Bug Fix (non-breaking change that fixes an issue)
[ ] Breaking Change (feature/fix that causes existing features to not work as expected)
[ ] Documentation

[x] I have read the [contribute]contributing doc
[x] Classes, scripts, and environment variables follow existing naming convention
[x] Lint and Unit tests pass locally
[x] New features on hardware have been tested on a local Raspberry Pi
[x] Mention new programs/binaries if any must be installed along with this change
[x] Mention new environment variables if any have been added to hardware/env file
[x] Please make sure test coverage does not drop. If it does, please explain the reasons.
[x] Any new required python modules are added to the requirements.txt

VentusXu09 commented 4 years ago

Hi, the branch is out of date, please sync with the master branch.

yashasvid commented 4 years ago

I am creating a new PR with some more tests.