Feat/gps speed - Githubissues

yashasvid commented 4 years ago

Title

Added more tests to gps module

This PR adds more tests to the gps module aiming to improve coverage.

Put an x in the boxes that apply

[x] Feature (non-breaking change which adds functionality)
[ ] Bug Fix (non-breaking change that fixes an issue)
[ ] Breaking Change (feature/fix that causes existing features to not work as expected)
[ ] Documentation

[x] I have read the [contribute]contributing doc
[x] Classes, scripts, and environment variables follow existing naming convention
[x] Lint and Unit tests pass locally
[x] New features on hardware have been tested on a local Raspberry Pi
[x] Mention new programs/binaries if any must be installed along with this change
[x] Mention new environment variables if any have been added to hardware/env file
[x] Please make sure test coverage does not drop. If it does, please explain the reasons.
[x] Any new required python modules are added to the requirements.txt

VentusXu09 commented 4 years ago

IMO, the git-flow should be team-feature-branch -> team-master-branch->class-master branch.

And I found you create another pull request merging this branch into the hardware-team. This may create conflicts between master and hardware-team.

So can you create another ticket to merge hardware-team into master after feat/gps-speed is merged into hardware-team?

BTW you don't need to close the last pull request, because it will update automatically when you push new commits into your branch.

yashasvid commented 4 years ago

Agreed. I will create another ticket once this PR is merged into hardware-team

PrabhanshuAttri commented 4 years ago

@yashasvid I have changed the base branch to hardware-team. You won't have to create another PR