gcivil-nyu-org / wed-fall24-team2

4 stars 2 forks source link

[BUG] Popup to upload sounds appears only after multiple clicks/attempts #192

Open arsalananwar11 opened 5 hours ago

arsalananwar11 commented 5 hours ago

Popup to upload sounds appears only after multiple clicks/attempts

Steps to reproduce:

Attaching video reference:

https://github.com/user-attachments/assets/1367473d-804f-4321-a151-ce19c1dbe595

soniasusanto commented 4 hours ago

There is a certain radius which we allow adding the next marker, that is why you see that you can't add the next marker unless you move the cursor a little further away. We developed it this way because we don't think that two points being very close to each other can potentially have different sounds. You could submit a feature request though.

arsalananwar11 commented 4 hours ago

There is a certain radius which we allow adding the next marker, that is why you see that you can't add the next marker unless you move the cursor a little further away. We developed it this way because we don't think that two points being very close to each other can potentially have different sounds. You could submit a feature request though.

Hey Sonia, thanks for clarifying that the radius check is in place but it seems like the checks dont work because I was able to add the sound really close to the other sounds but for the others i.e. for same radius or beyond, I am not able to add.

Also, as shown in the video, I was initially able to place the sound blip close to one of the other blips but after that I was not able to add it again.

https://github.com/user-attachments/assets/343977ff-edf6-42bd-840b-b6a37cc7c40c

soniasusanto commented 4 hours ago

Thanks, the radius checks are only for the marker you are trying to add, so it checks the one you added and the other one you're trying to click. It does not check pre-existing ones but I see this can be a confusing user experience so we'll consider this feature enhancement.