search

gcivil-nyu-org / wed-fall24-team4

1 stars 1 forks source link

test party bug - Geocoding failed for origin: ZERO_RESULTS (Routing doesn't work) #164

Open KartikeySharma opened 15 hours ago

KartikeySharma commented 15 hours ago

Note: I have tested this out, and I don't think its a text or geocoding issue.

Issue:

Adding a Start Location and End Location of 103 St and 8 St NYU leads to the following alert message _"Geocoding failed for origin: ZERORESULTS"

Steps to Reproduce:

  1. Login / Don't Log In
  2. Allow Location Access (visible in recording)
  3. Enter 103 St and 8 St NYU as the Start and End Location respectively.
  4. Click Find Route, the error should pop up.

Where is the error being triggered:

console.log("Geocoding failed for origin:", status) in map.html -> Link to Exact Line on Github Repo

Recording:

Screenshot:

(Start is 103 St and End Location is 8 St NYU -> will be visible in recording though) image

Note: This is not mentioned in the testing doc as of 11/13/2024 at 8:47 PM

seanpanpan321 commented 12 hours ago

This behavior is expected because manually entering ‘103 St’ can reference multiple locations, such as various street addresses or different subway station entrances (there are 3). This ambiguity is similar to entering a name like ‘Trader Joe’s,’ which can result in a ‘Geocoding failed for origin: ZERO_RESULTS’ error if the system cannot pinpoint the specific Trader Joe’s that the user is referencing. However, when the subway station is selected from a list, the app uses a specific geolocation, making it identifiable.

However, we agree that it might be confusing for the end user, as it appears the same text input produces different results. We will try to give visual hints so it is clearer.

KartikeySharma commented 2 hours ago

So how about we choose any one (of those 3) or notify the user that there are 3 103St subway stations? Maybe some form of user aide could be helpful.

Maybe a better alert message saying that "There are 'n' 103 St stations in NYC"?