search

gclayburg / synology-diskstation-scripts

Update Synology DNS records from DHCP IP address reservation
169 stars 41 forks source link

Synology S99pollDHCP.sh not working on DSM 6.0.1 #14

Closed paulsep closed 8 years ago

paulsep commented 8 years ago

While the ps command has been changed in DSM 6.0.1, you'll get an error, when checking, whether poll-dhcp-changes.sh is running or not.

The lines in S99pollDHCP.sh should read: POLL_RUNNING=ps x | grep poll-dhcp-changes | grep -v grep |wc -l MYPID=ps x | grep poll-dhcp-changes | grep -v grep | awk -F' ' '{print $1}'

Same issue in startDHCP-DNS.sh. Should read: POLL_RUNNING=ps x | grep poll-dhcp-changes | grep -v grep |wc -l

gclayburg commented 8 years ago

Thanks for this report. I'll incorporate these fixes soon.

tonysurma commented 8 years ago

Again thanks for this. I think I have this fixed in PR in my fork without fuzzing the file with windows cruft.

gclayburg commented 8 years ago

@tonysurma I just added a fix that should work on both DSM 5 and 6. Do you mind testing it under DSM 6? I don't have a DSM 6 box for testing.

paulsep commented 8 years ago

@gclayburg I guess you tried to send me the fix via email. I'm sorry, but my mailserver does not accept any kind of script files, send by email, cause of potential viruses. You have to compress the fix as zip or rar to send it to me by email.

Again, sorry for that.

tonysurma commented 8 years ago

@gclayburg I will test it on 6 this weekend. Thanks

gclayburg commented 8 years ago

@paulsep That must've been github being all inclusive when your issue is updated. Everything relevant to this issue can be found in this repository and my recent commits.

tonysurma commented 8 years ago

FWIW 24 days later this is fixed in your repo - thanks!