search

gclayburg / synology-diskstation-scripts

Update Synology DNS records from DHCP IP address reservation
169 stars 41 forks source link

Fix gclayburg #23 #33

Open abitgeeky opened 4 years ago

abitgeeky commented 4 years ago

PR for user32000 fix for SOA serial bleed problem resulting in additional \t; 1 serial numbers being appended to the zone file.

gclayburg commented 4 years ago

boy, it has been a while since I've looked at this code. It might be a few days before I have time to review it. I assume this fix is working for you?

cdjohnson commented 4 years ago

boy, it has been a while since I've looked at this code. It might be a few days before I have time to review it. I assume this fix is working for you?

Yes, I had to fix a few bugs in the original commits.

I deployed this on my ds418play and then forced a bunch of DCHP updates and static updates to make sure the zone file didn't get clobbered. It's been running for a week now without any problem.

jglathe commented 3 years ago

Integrated it, too. It's running now n my ioSafe N2, so far no issues.

jglathe commented 3 years ago

Well, that cratered pretty quickly. The script is killing the static sections (SOA record) and the NS record and serial. crater Also, the static addresses are likewise not preserved. Seems like there is still some work to do.

abitgeeky commented 3 years ago

I actually fixed this a month ago, but forgot to push it to github. Try again.

jglathe commented 3 years ago

Hey, thanks. I'll try it out tomorrow, just finished fixing up the zone files. Have to find a way to preserve the static entries, though. Never thought I would look into coding sript...