Rietveld code review requests and updates don't send email notifications

[GoogleCodeExporter]

What steps will reproduce the problem?
1. run upload.py
2. start a review in the URL returned by upload.py

What is the expected output? What do you see instead?

Until recently the people from whom you requested a review would get an email 
notification. Now they don't.

This problem happens for the original review request as well as when you upload 
changes in response to a review. Strangely, when the reviewer finishes 
reviewing the code, the code author does seem to get that notification.

What browser are you using?  What version? On what operating system?

Chrome 16.0.912.36 beta running on Linux.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

codereview.appspot.com

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

I am a Google employee: mfschwartz@google.com

Please provide any additional information below.

Original issue reported on code.google.com by mfschwa...@google.com on 18 Nov 2011 at 5:15

[GoogleCodeExporter]

We just made a config change and this should now work again. If it doesn't, 
please reopen this issue.

Original comment by gvanrossum@gmail.com on 18 Nov 2011 at 5:22

• Changed title: Rietveld code review requests and updates don't send email notifications
• Changed state: Fixed

[GoogleCodeExporter]

It seems to be 'Authentication Options' menu that is also displayed when 
creating app. But I couldn't find the option. The closes one:

"""Open to all Google Accounts users (default)

If your application uses authentication, anyone with a valid Google Account may 
sign in. (This includes all Gmail Accounts, but does *not* include accounts on 
any Google Apps domains.)"""

Does that mean that Rietveld is special? And users won't be able to login into 
my AppEngine application with their non @gmail Google accounts?

Original comment by techtonik@gmail.com on 18 Nov 2011 at 9:05

[GoogleCodeExporter]

No, it has nothing to do with that option.  That option selects the 
*authentication* method.  Choices are "Google Accounts" (not quite the same as 
GMail account but open to anyone in the public); "Google Accounts for your 
domain" (for corporate Google Apps users) and OpenID.

If you select Google Accounts (the default), anyone with a non-corporate Google 
Account can log in to your app, regardless of whether the email associated with 
the account is GMail or a 3rd party email address.

However *this* issue is about email sent from the app.  An app can send email 
either from any of the app admins or from the currently-logged-in user.  
However an additional restriction is that the email address used to send email 
must also be either a GMail address or a corporate Google Account.  Rietveld 
indeed has a special permission to bypass this additional restruction.

Original comment by gvanrossum@gmail.com on 18 Nov 2011 at 10:00

[GoogleCodeExporter]

> If you select Google Accounts (the default), anyone with a non-corporate 
Google Account can log in to your app, regardless of whether the email 
associated with the account is GMail or a 3rd party email address.

Actually I think most corporate account users can log in too.  For legacy 
domains some kind of conversion must have been approved by the domain admins, 
but AFAIK most domains have gone through that by now.

Original comment by gvanrossum@gmail.com on 18 Nov 2011 at 10:04

[GoogleCodeExporter]

Just to be clear: I've been using Rietveld for code reviews for 8+ months
between my corp account and other corp accounts as well as other gmail
accounts. Notifications used to work. Nothing in my email address changed,
so it seems like something in the app or its configuration changed and
stopped working wrt notifications recently.

Original comment by mfschwa...@google.com on 18 Nov 2011 at 10:36

[GoogleCodeExporter]

Yeah, and we fixed it this morning. (The temporary breakage was because we 
actually migrated to a new app instance, and this special configuration bit was 
not set for that instance initially.)  So please try it and let me know 
(offline) if it is still broken.

Original comment by gvanrossum@gmail.com on 18 Nov 2011 at 10:38

[GoogleCodeExporter]

Oh, right, you said that it was fixed before. Sorry, it's been a busy day.

I'll let you know if it's still not fixed next time I try it. Thanks.

Original comment by mfschwa...@google.com on 18 Nov 2011 at 10:45

[GoogleCodeExporter]

This problem seems to have recurred. Today I created two Rietveld reviews 
(http://codereview.appspot.com/5447048 and 
http://codereview.appspot.com/5434083) and I got the notification but the 
reviewer did not.

Original comment by mfschwa...@google.com on 30 Nov 2011 at 1:38

[GoogleCodeExporter]

Hi - FYI Rietveld regularly fails to send email notifications when we use it 
for code reviews. We have gotten in the habit of always sending our own emails 
to one another when we send a request for a review or when we perform a review.

This most recently happened today (2/20/2012), and every time I've used 
Rietveld in the past few weeks.

Original comment by mfschwa...@google.com on 20 Feb 2012 at 4:17

[GoogleCodeExporter]

Which Rietveld instance are you using? codereview.appspot.com or your own 
instance? Which email was used for the sender (i.e. the email of the logged-in 
user)? Which issue#? Which recipients? Have you checked for typos? Have the 
receivers thoroughly searched their spam folders?

Original comment by gvanrossum@gmail.com on 20 Feb 2012 at 4:37

[GoogleCodeExporter]

codereview.appspot.com

Which email was used for the sender (i.e. the email of the logged-in user)?

marccohen@google.com

http://codereview.appspot.com**/5688051/<http://codereview.appspot.com/5688051/>

myself (mfschwartz@google.com)

This happens regularly, so it's definitely not a case of typos.

I just looked now, and I have only 2 messages in my spam folder, neither of
which is a Rietveld notification.
This is for a code review request sent by Marc last night.

Mike

Original comment by mfschwa...@google.com on 20 Feb 2012 at 4:47

[GoogleCodeExporter]

Which UI did you use to send the email? The web UI, or some upload.py command? 
There are known issues where upload.py often doesn't send mail.

Original comment by gvanrossum@gmail.com on 21 Feb 2012 at 6:11

[GoogleCodeExporter]

The web UI. Specifically, I edit the issue and add my reviewers, then go
publish the issue. When that's done I see the notification my the person to
whom I sent the review does not. (I regularly see the latter myself, being
a reviewer that doesn't get notifications)

Original comment by mfschwa...@google.com on 21 Feb 2012 at 6:41

[GoogleCodeExporter]

Could you try (or ask) sending a test message for that same issue and let me 
know if the email arrived or not?  I'd like to look through the logs but it's 
hard to browse back to day-old logs.  I'm also entertaining the possibility 
that, since both of you are using your @google.com address, there's a 
Google-specific ban on email sent by external mail servers appearing to come 
from another @google.com account.  (For all intents and purposes, App Engine is 
considered external infrastructure.)

Original comment by gvanrossum@gmail.com on 21 Feb 2012 at 6:49

[GoogleCodeExporter]

Hi - when you say "try sending a test message for that same issue" I'm not
sure what you're suggesting. Do you mean to Publish + Mail Draft Comments
from the Rietveld UI? Or did you mean to send email to
reply@codereview-hr.appspotmail.com, with the issue number in the subject
line? Or ... ?

Original comment by mfschwa...@google.com on 22 Feb 2012 at 3:30

[GoogleCodeExporter]

Sorry, I meant use Publish + Mail Draft Comments.  I don't know what timezone 
you are in, but could you coordinate this via chat so I am online when you do 
the test?

Original comment by gvanrossum@gmail.com on 22 Feb 2012 at 3:47

[GoogleCodeExporter]

(That is, chat to guido@google.com.)

Original comment by gvanrossum@gmail.com on 22 Feb 2012 at 3:47

[GoogleCodeExporter]

We debugged this offline and found that it was a usability issue, not a bug: 
the user expected "edit issue" to send email when a reviewer was added, but the 
code doesn't do this. I filed issue 372 to track this usability issue.

Original comment by guido@google.com on 23 Feb 2012 at 1:29