upload.py do not detect subversion 1.7.* subversion working copy

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
if you use subversion 1.7 , there is now a centralized .svn  (see 
http://subversion.apache.org/docs/release-notes/1.7.html#wc-ng ), and thus the 
way upload.py is trying to detect the VCS is obsolete.

A workaround is to use   -vcs svn , but this is not user friendly.

A possible correction would be to use

  # from 1.7 svn has a single .svn folder 
  # Try running it, but don't die if we don't have svn installed.
  res = RunDetectCommand(VCS_SUBVERSION, ["svn", "info"])
  if res != None:
    return res

It should work fine even for subversion earlier that 1.7

Original issue reported on code.google.com by jocelyn.fiat on 9 Jan 2012 at 9:12

GoogleCodeExporter commented 9 years ago

Thanks for the info. Can you upload the change for review? 
http://code.google.com/p/rietveld/wiki/Contributing

Original comment by techtonik@gmail.com on 9 Jan 2012 at 10:03

GoogleCodeExporter commented 9 years ago

See http://codereview.appspot.com/5529052/

Original comment by jocelyn.fiat on 9 Jan 2012 at 1:12

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 18cdd04ef90a.

Original comment by techtonik@gmail.com on 10 Jan 2012 at 9:27

Changed state: Fixed

gco / rietveld

upload.py do not detect subversion 1.7.* subversion working copy #359