invalid utf8 data in patch cause rietveld to crash

gco / rietveld

Automatically exported from code.google.com/p/rietveld

Apache License 2.0

0 stars 0 forks source link

invalid utf8 data in patch cause rietveld to crash #375

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

URL: http://codereview.appspot.com/5849053/

Output of rietveld when I tried to mail the drafts:
Sorry, an error occurred...

Unhandled exception.

Details: 'utf8' codec can't decode bytes in position 1062-1063: invalid data.

Original issue reported on code.google.com by minux...@gmail.com on 17 Mar 2012 at 7:50

GoogleCodeExporter commented 9 years ago

Does you patch contain Chinese characters in some exotic encoding?

Original comment by techtonik@gmail.com on 17 Mar 2012 at 4:37

Added labels: Component-Engine

GoogleCodeExporter commented 9 years ago

I think it is because the original file contains some corrupted utf-8 character.
http://codereview.appspot.com/5849053/diff/2001/src/cmd/godoc/README.godoc-app#o
ldcode50
http://code.google.com/p/go/source/browse/src/cmd/godoc/README.godoc-app#50
(the quotation mark around "documentation")

Original comment by minux...@gmail.com on 18 Mar 2012 at 7:04

GoogleCodeExporter commented 9 years ago

So, what do you think Rietveld should do?

Original comment by techtonik@gmail.com on 18 Mar 2012 at 7:14

GoogleCodeExporter commented 9 years ago

It now crashes when I'm sending out mails, so I think Rietveld should ignore 
the encoding
error and proceed.
(It can point it out in the mail it sends so that the reviewers will be aware 
of the encoding
problem)

Thanks.

Original comment by minux...@gmail.com on 18 Mar 2012 at 7:18