Closed GoogleCodeExporter closed 9 years ago
This change was intentional (see revision 140baeb01745) to allow line by line
navigation and addin comments by pressing "Enter" on every line. Why do you
think that this behavior differs so much from the default browser behavior?
Original comment by albrecht.andi
on 8 May 2012 at 7:06
Working as intended.
Original comment by gvanrossum@gmail.com
on 8 May 2012 at 7:40
Because I use the arrow keys to scroll the page of diffs as a whole. Now
in order to get the first scroll down, I have to scroll below the entire
first page, one line at a time. Also, this skips over blocks of
commentary, which could be quite long. Perhaps I'm reading a long block of
reviewer's comments and want to scroll through them.
Also, the scrolling, when the highlight line moves off the screen, is emacs
style half-page at a time, whereas the arrow keys generally scroll 2 or 3
lines at a time, depending on text size.
Maybe I'm in the minority, but I think it's kind of jarring when a web page
takes an action on one of the standard keys on the keyboard. It'd be
different if the highlight line could be selected with the mouse, reacted
to pageup and pagedown, allowed focusing and scrolling through commentary,
and reacted to the overall page scrollbars on the document, as that'd at
least work as expected.
Here's an experiment: Press Up or down once, scroll to the bottom of a diff
page using the browser scroll bar, now press up again. I think you can
easily observe that it isn't the same as in a normal web page.
Original comment by art.yer...@gmail.com
on 8 May 2012 at 7:58
We can't make everyone happy, sorry.
Original comment by gvanrossum@gmail.com
on 8 May 2012 at 8:30
You encouraged me to try out noscript, so it's not a total loss, I suppose.
Original comment by art.yer...@gmail.com
on 8 May 2012 at 8:44
Issue 380 has been merged into this issue.
Original comment by gvanrossum@gmail.com
on 11 May 2012 at 11:09
You could make most people happy by using a different set of keys for the line
by line navigation and leaving arrow keys as they should be.
Original comment by mattm@chromium.org
on 11 May 2012 at 11:17
That would make most current users unhappy though. And no, I'm not going to add
a config option.
Original comment by gvanrossum@gmail.com
on 11 May 2012 at 11:29
I'd say we - open two issues and propose people to vote for it.
Original comment by techtonik@gmail.com
on 12 May 2012 at 5:33
Original issue reported on code.google.com by
art.yer...@gmail.com
on 8 May 2012 at 6:02