Closed GoogleCodeExporter closed 9 years ago
I have to agree that something's not quite right with this feature. The way we
had it implemented in Mondrian, moving the blue marker down by one line would
simultaneously scroll the window up the same amount. But the way it's done now
in Rietveld, the blue marker moves all the way to the top or bottom of the
window before scrolling occurs, and then it jumps by almost a whole page.
Also, I find that in Firefox (FF 12.0 on Linux at least) the page up/down keys
have stopped working.
Andi, can you revisit this? I think that some previous recent complaints about
the blue marker also had to do with this -- I'd forgotten that there was a
functionality change. Or perhaps something else more recently made it worse???
I don't recall noticing this during the review.
Original comment by guido@google.com
on 22 May 2012 at 10:23
If the screen still scrolled as normal, I certainly wouldn't mind that the
marker moved in the opposite direction.
Original comment by ericu@chromium.org
on 22 May 2012 at 10:25
Agreed, this came up so often in the last few weeks, I'll have a look at it
ASAP.
Original comment by albrecht.andi
on 23 May 2012 at 6:56
I've uploaded a modified version that scrolls immediately to my test instance:
See for example http://rvtests.appspot.com/73842/diff/1/upload.py
Is this behavior better?
Original comment by albrecht.andi
on 23 May 2012 at 8:10
Yes, it's much better.
It's a significantly slower scroll than a normal web page, which is a little
odd, but I can deal with that.
Thanks!
Original comment by ericu@chromium.org
on 23 May 2012 at 3:42
Review: http://codereview.appspot.com/6221068
Original comment by albrecht.andi
on 23 May 2012 at 7:15
This issue was closed by revision d86fc9600d63.
Original comment by albrecht.andi
on 24 May 2012 at 6:25
Original issue reported on code.google.com by
ericu@chromium.org
on 22 May 2012 at 9:57