gco / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

GWT assumes window.location is constant, which is not true when using history.pushState #402

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The HTML 5 window.history.pushState method modifies the value of 
window.location without a browser reload.

This breaks the assumption in GWT's Window.Location class: window.location is 
not immutable anymore,
and therefore there needs to be a way to update the static variables
Window.Location.paramMap and listParamMap.

Tested using Chrome 23 on Ubuntu.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

http://code.google.com/p/rietveld/

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***
I am a Google employee.

Original issue reported on code.google.com by pern...@google.com on 5 Nov 2012 at 4:31

GoogleCodeExporter commented 9 years ago
(Submitter said they'd filed this in the wrong tracker.)

Original comment by gvanrossum@gmail.com on 5 Nov 2012 at 11:18