gco / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

email replies to issues are being lost #406

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. receive email notification of a code review
2. reply via email with comment

What is the expected output? What do you see instead?

Expected: Comment appears in the code review comments section

Actual: No comment appears, after 24 hours a delivery failure notification is 
transmitted to the sender

Please provide any additional information below.

Sample below:

Delivery to the following recipient failed permanently:

     reply@codereview-hr.appspotmail.com

----- Original message -----

Received: by 10.42.159.136 with SMTP id l8mr4789909icx.10.1354441619635;
        Sun, 02 Dec 2012 01:46:59 -0800 (PST)
Return-Path: <dave@cheney.net>
Received: from mail-oa0-f53.google.com (mail-oa0-f53.google.com [209.85.219.53])
        by gmr-mx.google.com with ESMTPS id x4si523286igm.0.2012.12.02.01.46.59
        (version=TLSv1/SSLv3 cipher=OTHER);
        Sun, 02 Dec 2012 01:46:59 -0800 (PST)
Received-SPF: neutral (google.com: 209.85.219.53 is neither permitted nor 
denied by best guess record for domain of dave@cheney.net) 
client-ip=209.85.219.53;
Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 
209.85.219.53 is neither permitted nor denied by best guess record for domain 
of dave@cheney.net) smtp.mail=dave@cheney.net
Received: by mail-oa0-f53.google.com with SMTP id j6so1976836oag.26
        for <reply@codereview-hr.appspotmail.com>; Sun, 02 Dec 2012 01:46:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding:x-gm-message-state;
        bh=o8/entU9TRe9oBBXV4rfXT4omKbcMJimuFH9xfkSRNM=;
        b=GeCmXmmr2ist0H981m/Eap2jPMkbwxKmg/EURtpcbea2ft1aXFilxVstW1hOw1PXcP
         iGLuKbz8RN6RWGICdIvWMw+pvN4sbOC95qu2o4HqQBYqkioh6Jhhu4jMHepQIzpPiLX/
         VvnF4dFlTUtrx7DVgHuu0CVF3F5nGeNoh7jmoRcssGl54hg2wMSIIP3MSEKsad02X+Gg
         09+26tdBD37o6EHF6Y+NiTL92xrl7Mz7rhWg5Phk5nA2Yg7AE7SZptk5KHkHwJvqOmYE
         7bVL9dcAE7lzpF6QCiPUYC/FSyTIyoO0Nuvc0l/RSiv2Bm3c37NL7Nj2IuBWmzJhz0uU
         Zdiw==
MIME-Version: 1.0
Received: by 10.60.6.170 with SMTP id c10mr5441298oea.82.1354441619354; Sun,
 02 Dec 2012 01:46:59 -0800 (PST)
Received: by 10.182.85.193 with HTTP; Sun, 2 Dec 2012 01:46:59 -0800 (PST)
In-Reply-To: 
<CADEq3_vOSy+523ExfgPPR6_bo9+51n7Sw=J9VjnF33Bw5xQhHQ@mail.gmail.com>
References: <089e013cc3642e67b204cfc4aba3@google.com>
        <CADEq3_vOSy+523ExfgPPR6_bo9+51n7Sw=J9VjnF33Bw5xQhHQ@mail.gmail.com>
Date: Sun, 2 Dec 2012 20:46:59 +1100
Message-ID: <CANp9fE9fW0mHeJQKq2i2u5c5ev3XQ=csDbj+EYCniK9+3h1YYA@mail.gmail.com>
Subject: Re: [golang-dev] Re: code review 6842127: net: align deadline fields
 on 8 byte boundaries (issue 6842127)
From: Dave Cheney <dave@cheney.net>
To: =?ISO-8859-1?Q?R=E9my_Oudompheng?= <remyoudompheng@gmail.com>
Cc: reply@codereview-hr.appspotmail.com,
        Brad Fitzpatrick <bradfitz@golang.org>, minux.ma@gmail.com, golang-dev@googlegroups.com,
        rsc@golang.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: 
ALoCoQkrqaJs88lxZt/Pmmn+CikXg7ttRSzNugFkn0z3u98uPNvZ03aXx3781MbkcHjMtKYf4SDs

Original issue reported on code.google.com by d...@cheney.net on 3 Dec 2012 at 7:56

GoogleCodeExporter commented 9 years ago

Original comment by john.abd...@gmail.com on 4 Dec 2012 at 8:31

GoogleCodeExporter commented 9 years ago
This appears to be Rietveld's fault. It is replying to /_ah/mail HTTP requests 
with 301s trying to force the use of https. I've changed the default version 
running on codereview.appspot.com back to version 102, which predates the https 
forcing.

Original comment by rsc@golang.org on 6 Dec 2012 at 6:20

GoogleCodeExporter commented 9 years ago
Mail is processed via a http hammer ?!?

/me reaches for a larger hammer.

Original comment by d...@cheney.net on 6 Dec 2012 at 6:22

GoogleCodeExporter commented 9 years ago
rsc: thanks for tracking it down, I thought it was a regression somewhere else 
and had https://codereview.appspot.com/6870055/ ready to land.

maruel: in codereview\middleware.py
def process_request(self, request):
    if not request.is_secure():
      request_url = request.build_absolute_uri(request.get_full_path())
      return HttpResponsePermanentRedirect(
          request_url.replace('http://', 'https://'))

needs to be updated then to whitelist /_ah/mail?

Original comment by john.abd...@gmail.com on 6 Dec 2012 at 6:39

GoogleCodeExporter commented 9 years ago
I've committed this on trunk at 
https://code.google.com/p/rietveld/source/detail?r=bc39c6562b0956adff8c0086a4963
6a6fdc962f5

I don't have access to push updates on the AE instance, so someone with 
permission will have to do that.

Original comment by john.abd...@gmail.com on 10 Dec 2012 at 6:13