search

gco / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

A query is allowed to be executed that has no corresponding index #414

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The query

https://codereview.appspot.com/search?repo_guid=5c54f386432c6547d76465074e6ed7a6
4c17be69&closed=3

is linked to in the contributing wiki page for the "long list of patches",

The suggested index

- kind: Issue
  properties:
  - name: closed
  - name: repo_guid
  - name: modified
    direction: desc

is not in
http://code.google.com/p/rietveld/source/browse/index.yaml

It seems SearchForm.is_valid could be overridden to only allow queries with a 
corresponding index.

Here is the offending code:
http://code.google.com/p/rietveld/source/browse/codereview/views.py?r=ba73338a28
b89b50c07e21c5f6edbcc4dfacec61#3466

See http://code.google.com/p/rietveld/issues/detail?id=413 for original 
reference.

Original issue reported on code.google.com by dhermes@google.com on 22 Jan 2013 at 8:29

GoogleCodeExporter commented 9 years ago 
Working on a patch that uses the search API instead.

Original comment by albrecht.andi on 17 Jun 2013 at 7:34