search

gco / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Assertion when asking for feed by e-mail #418

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Simple repro:

https://codereview.chromium.org/user/arv@chromium.org

Note the assertion.

this is because models.Accounts.get_account_for_nickname() asserts '@' not in 
nick

Patch attached.

Original issue reported on code.google.com by alecflett@chromium.org on 25 Jan 2013 at 8:45

Attachments:

GoogleCodeExporter commented 9 years ago 
Hm... It seems that this repro link works now... Did this get implemented since 
you filed the bug?

Original comment by iannu...@google.com on 30 Mar 2013 at 1:16

GoogleCodeExporter commented 9 years ago 
Hmmm.. I think that link didn't work at the time. But this still fails until 
this patch is applied: 

https://codereview.chromium.org/rss/mine/arv@chromium.org

Original comment by alecflett@chromium.org on 30 Mar 2013 at 4:23

GoogleCodeExporter commented 9 years ago 
I guess that /rss/mine/ URL should only work for authenticated users and don't 
require email name in GET request, no?

Original comment by techtonik@gmail.com on 4 Apr 2013 at 5:25

GoogleCodeExporter commented 9 years ago 
Well the URL might be strange, but I think the point is it should be possible 
to get an RSS feed of anyone's CL's. 

This works:
https://codereview.chromium.org/rss/mine/arv

Except that not everyone's codereview nickname is the same as just the head of 
their e-mail address, the same way you can see someone's regular code review 
page:
https://codereview.chromium.org/user/Marc-Antoine%20Ruel

Reason I want this: I have a tool for dynamically watching specific people's 
CLs and there is no programmatic way to lookup someone's "nickname" from their 
email address.

For instance:
https://codereview.chromium.org/rss/mine/tsepez@chromium.org
https://codereview.chromium.org/rss/mine/tsepez

(Tom's nickname is "Tom Sepez" not "tsepez")

Original comment by alecflett@chromium.org on 5 Apr 2013 at 5:22

GoogleCodeExporter commented 9 years ago 
@ are not allowed in nicknames so you cannot impersonate another email address. 
I'd recommend marking this bug as WontFix.

Original comment by maruel@chromium.org on 16 Oct 2013 at 4:43