gco / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

upload.py doesn't follow gitignore rules #461

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add a file without a \0 in it, add binary data, especially newlines, cr in 
weird combinations. Don't give it an image related file ending.
2. Mark this as not being text in the gitignore files
3. Upload

What is the expected output? What do you see instead?

The upload script will assume that it is text and mangle all line endings and 
corrupt the binary file.

Original issue reported on code.google.com by ti...@opera.com on 11 Sep 2013 at 1:13

GoogleCodeExporter commented 9 years ago
I don't see a way to edit the original post but I'm talking about gitattributes 
here not gitignore

Original comment by ti...@opera.com on 19 Sep 2013 at 6:21