tracks with (fixable) errors not always encoded

[GoogleCodeExporter]

When Rubyripper is attempting to rip a full CD, some of the tracks with
errors may not be encoded (to FLAC in this case) after the errors are
fixed. No indication is given that not all tracks were encoded.

This happened with a few CDs, but for the CD below (partial log 1):
track 1 encoded like it was supposed to, as did every other track except
track 2, which wasn't encoded at all. Tracks 1 and 2 were the only ones
with reported errors.

Re-ripping track 2, by itself, seems to have worked (partial log 2).

I am using Ubuntu 7.04, GNOME,  and running Rubyripper with gtk2 (i assume,
as it's not the CLI).

---------------(partial log 1)------------------
This log is created by Rubyripper, version 0.4.2
Website: http://code.google.com/p/rubyripper

Cdrom player used to rip:
SONY DVD RW DW-U12A 2.0b
Cdrom offset used: 0

Ripper used: cdparanoia (-Z)
Matches required for all chunks: 2
Matches required for erronous chunks: 2

Codec(s) used:
-flac   -> --best (flac 1.1.2)

CDDB INFO

Artist  = Secondhand Serenade
Album   = Awake
Year    = 2007
Genre   = rock
Tracks  = 12

01 - Half Alive
02 - Broken
03 - Vulnerable
04 - Your Call
05 - Maybe
06 - It's Not Over
07 - I Hate This Song
08 - Awake
09 - Take Me With You
10 - Let It Roll
11 - Last Song Ever
12 - End

STATUS

Starting to rip track 1, trial 1#
Starting to rip track 1, trial 2#
Analyzing files for mismatching chunks
35 chunk(s) didn't match 2 times.
Starting to rip track 1, trial 3#
Error(s) succesfully corrected, 2 matches found for each chunk :)
MD5 sum: ee60a523483d5a401efc8383916e6a26

Starting to rip track 2, trial 1#
Starting to rip track 2, trial 2#
Analyzing files for mismatching chunks
20 chunk(s) didn't match 2 times.
Starting to rip track 2, trial 3#
Error(s) succesfully corrected, 2 matches found for each chunk :)
MD5 sum: 28066405d82ba22f598ea30d2f6d0f59

Starting to rip track 3, trial 1#
Starting to rip track 3, trial 2#
Analyzing files for mismatching chunks
Every chunk matched 2 times :)
MD5 sum: 6ad32a5f2c1a52b7ae4520d132e09319

---------------(partial log 2)------------------
Starting to rip track 2, trial 1#
Starting to rip track 2, trial 2#
Analyzing files for mismatching chunks
26 chunk(s) didn't match 2 times.
Starting to rip track 2, trial 3#
Error(s) succesfully corrected, 2 matches found for each chunk :)
MD5 sum: ab378212eee2279e7cfbfe90fe4ba34d

Original issue reported on code.google.com by benbla...@gmail.com on 19 Jul 2007 at 5:10

[GoogleCodeExporter]

Sounds kinda strange to me. Can anyone else confirm this bug? I'll do some 
testing 
though.

Original comment by rubyripp...@gmail.com on 19 Jul 2007 at 6:21

[GoogleCodeExporter]

I'm having similar issues even with correctly ripped tracks :

Artist  = Jose Padilla
Album   = Cafe Solo CD1
Year    = 2006
Genre   = chill out
Tracks  = 14

According to the log track 13 is read 2 times identical :

Starting to rip track 13, trial 1#
Starting to rip track 13, trial 2#
Analyzing files for mismatching chunks
Every chunk matched 2 times Smiley
MD5 sum: 35b3857e3dac9a99e6f1c9f6fde3d1d8

But running flac -t on files generated through rubyripper reveals the following 
:

13 - Take It Slow.flac: testing, 36% complete13 - Take It Slow.flac: *** Got 
error
code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
13 - Take It Slow.flac: *** Got error code 2:FLAC__STREAM_DECODER_ERROR_STATUS_F
RAME_CRC_MISMATCH

Used flac version = flac 1.1.2

Original comment by audioha...@gmail.com on 28 Aug 2007 at 5:37

[GoogleCodeExporter]

Seems XFS + Promise PDC20262 was causing integrity errors. So rubyripper is not 
at
fault here. But it would useful to have a flac test after encoding to flac. I
discovered this corruption after ripping 50 CD's :( My mistake.

Original comment by audioha...@gmail.com on 29 Aug 2007 at 4:57

[GoogleCodeExporter]

I'll look into a way to do this. Any suggestions are welcome. Does the encoding 
also exit with a failure?

Original comment by rubyripp...@gmail.com on 29 Aug 2007 at 5:19

• Changed state: Accepted

[GoogleCodeExporter]

With commit 166 each encoding process is checked for it exit code. If this is 
different than zero, a big WARNING will show up on your screen. I suppose this 
will 
be enough to solve problems like the above. 

If not, please open up a new issue.

Original comment by rubyripp...@gmail.com on 25 Nov 2007 at 11:50

• Changed state: Fixed