search

gco / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

%va does not work anymore #422

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1) Please describe the steps to reproduce the situation:
a. Process a CD marked as "Various artist".

2) What is the expected output? What do you see instead?
The generated filename when using format "%n-%va---%t" is
"01-Various---Title.flac" instead of "01-Kid_Rock---Title.flac" as in older
rrip_gui version.  
In the preferences rubyripper shows the Example filename correctly for
Various artists, "01-Kid_Rock---Cowboy.

Also, in the FLAC file rubyripper generates correct tag "ARTIST=Kid Rock"
and "ALBUM ARTIST=Various".

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
rrip_gui git version 5c1db0d16399c187d1c36fa933ad37d631618a4c.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
No.

5) Does the problem happen with different discs? If not, please attach
the output of cdparanoia -Q.
Seems to happen with every various artists CD.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
Many.

Please provide any additional information below. The more usefull
information provided, the sooner it will be fixed.

ITYM "useful".

Original issue reported on code.google.com by sami.fa...@gmail.com on 25 May 2010 at 3:32

GoogleCodeExporter commented 9 years ago 
Well, I've changed the logic earlier this year due to another issue. I think, 
seeing 
your examples it's working correctly in fact. See also  
http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Encouraged_Tag_Standard
s as 
a starting point.

It is stated there that the album artist / various artist / %va should mean the 
overall artist name of the disc. It should be the same for all tracks. In your 
example it's doing just that. But it seems I forgot to update the example, I'll 
fix 
that in a minute ;)

To restore the old behaviour you should change your format to %n-%a---%t.

Original comment by boukewou...@gmail.com on 26 May 2010 at 7:15

GoogleCodeExporter commented 9 years ago 
Fixed with commit:
http://github.com/rubyripperdev/rubyripper/commit/f6df30a2d76176989064ff874892ca
7167cc
de58

Original comment by boukewou...@gmail.com on 26 May 2010 at 7:20