gco / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

`saveResponse': undefined local variable or method `filename' #427

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This was probably introduced in
http://github.com/rubyripperdev/rubyripper/commit/3df7173fdd1eb3e9b68a9a5a947369
ae6d4b3797

full trace:

Should all tracks be ripped ? (y/n)  [y] 
Tracks to rip are 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
/usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:1248:in `saveResponse': undefined
local variable or method `filename' for #<Metadata:0x00000002f42d90>
(NameError)
    from /usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:1266:in `saveChanges'
    from /usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:2455:in `settingsOk'
    from /usr/bin/rrip_cli:410:in `prepareRip'
    from /usr/bin/rrip_cli:331:in `showFreedbOptions'
    from /usr/bin/rrip_cli:305:in `showFreedb'
    from /usr/bin/rrip_cli:265:in `handleFreedb'
    from /usr/bin/rrip_cli:244:in `get_cd_info'
    from /usr/bin/rrip_cli:47:in `initialize'
    from /usr/bin/rrip_cli:486:in `new'
    from /usr/bin/rrip_cli:486:in `<main>'

Original issue reported on code.google.com by goo...@JonnyJD.net on 30 May 2010 at 2:42

GoogleCodeExporter commented 9 years ago
Guess what, I already fixed it 11 minutes ago ;)

Original comment by boukewou...@gmail.com on 30 May 2010 at 2:51

GoogleCodeExporter commented 9 years ago
For your information, I often review my own code before I push it to the 
server. Then 
I inspect it once more, since the github diff is quite nice to read. Sometimes 
I'll 
add a quick fix right after it.

Original comment by boukewou...@gmail.com on 30 May 2010 at 2:54