When ripping a disc, rip will fail if the destination directory or files already exist

[GoogleCodeExporter]

Currently, if I re-rip a disc, the rip will fail if the destination directory 
or files already exist (cdparanoia returns immediately when ripping to the 
temporary directory, and "Cdparanoia doesn't output wav files." is output).  
This appears to be tied to the fact that the temporary directory is not 
created, as revision f4594199c994 fixes this problem.

That said, as I examined the fix more closely, I became less confident that it 
is the correct way to go about fixing it, so I backed out that change.  I 
believe this is the case as it may have been colliding with some other patches 
I am working on to make a better outcome than it should have had (I am doubtful 
that the file names would have been correctly specified, for example).

Finally, even with this fixed, flac does not currently overwrite files the way 
it is set up (as it does not specify the "-f" flag), and as such, the encoder 
for it will fail.  This may be the case for other encoders as well, so it would 
probably be ideal to erase any duplicate files before encoding (e.g. by 
encoding to a temporary location and then overwriting any existing files by 
doing a move subsequent to that, since we probably don't know the output 
filename)

Original issue reported on code.google.com by comradec...@gmail.com on 20 Nov 2011 at 5:12

[GoogleCodeExporter]

In the 0.6.1 version there are 3 possibilities supported:
1) overwrite the dir
2) auto rename the dir
3) cancel the rip

I'd rather not have the user use the same dir to append to it. This gives 
plenty of difficulties for the playlist file, the logfile, extra checks if 
files already exist, etcetera.

It should be relatively simple to re-enable the old functionality.

Original comment by boukewou...@gmail.com on 20 Nov 2011 at 8:47

[GoogleCodeExporter]

If I may give you some general advice, it would be to merge often and correct 
afterwards for new insights. When in doubt, sometimes the best thing to do is 
to write some tests for the desired behaviour. It will help you focus on the 
desired outputs. Asking for feedback in a new issue will help you to decide the 
right course.

Original comment by boukewou...@gmail.com on 20 Nov 2011 at 10:56

[GoogleCodeExporter]

This functionality works again for some time, see also commit:
http://code.google.com/p/rubyripper/source/detail?r=1878b857a45d604817efcd021507
009432f3074f

Original comment by boukewou...@gmail.com on 11 Mar 2012 at 10:06

• Changed state: Fixed