search

gco / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Tracks with multiple indexes calculated incorrectly in cuesheets #553

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Indexes in cuesheets are being incorrectly offset by the length between INDEX 
00 and 01, which I think is the pre-gap.

An example is probably best. I'm using Badly Drawn Boy's "About a Boy" 
soundtrack as an example. On the album, two tracks have two indexes (pre-gaps). 
The following two cuesheet snippet were generated by rubyripper's stable branch:

TRACK 04 AUDIO
  TITLE "Dead Duck"
  PERFORMER "Badly Drawn Boy"
  INDEX 00 08:35:00
  INDEX 01 08:36:50

TRACK 06 AUDIO
  TITLE "I Love N.Y.E."
  PERFORMER "Badly Drawn Boy"
  INDEX 00 12:01:10
  INDEX 01 12:03:32

The following two cuesheet snippet were generated by rubyripper's master branch:

TRACK 04 AUDIO
  TITLE "Dead Duck"
  PERFORMER "Badly Drawn Boy"
  ISRC GBBKS0100451
  INDEX 00 08:36:50
  INDEX 01 08:38:25

TRACK 06 AUDIO
  TITLE "I Love N.Y.E."
  PERFORMER "Badly Drawn Boy"
  ISRC GBBKS0100452
  INDEX 00 12:03:32
  INDEX 01 12:05:54

In the master branch, the INDEX 00 has been offset forward 00:01:50, which is 
the same as the length between INDEX 00 and INDEX 01. Same thing for track 6, 
which is increased 00:02:22. 

I tried looking around at the cuesheet generation but the error didn't pop out 
at me. I've been able to repeat the issue with multiple CDs. Everything tested 
by ripping a single FLAC file with cuesheets.

Original issue reported on code.google.com by jmbyl...@gmail.com on 29 Dec 2012 at 10:47

GoogleCodeExporter commented 9 years ago 
Thanks for reporting, an obvious mistake indeed. Only happened with image 
ripping. Fixed with commit:
http://code.google.com/p/rubyripper/source/detail?r=8bb46bd02291588568581e247cc0
323fcb74796c

Original comment by boukewou...@gmail.com on 2 Jan 2013 at 8:26