gco / xee

Automatically exported from code.google.com/p/xee
74 stars 8 forks source link

Very Large Images Not Fitting to Screen Size #391

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
First of all, if you have any Haxies, InputManagers, SIMBL plugins or
similar operating system hacks installed, please remove them first, restart
the program, and make sure the bug is reproducible without them.

What steps will reproduce the problem?
1. Open Very Large JPG file
2. Seems like it scales to width of Monitor, but not to Height.  Something like 
that.  It was immediately noticeable.

What version of the product are you using? On what operating system?
The newest one, from the App Store.

Original issue reported on code.google.com by obij...@gmail.com on 26 Oct 2013 at 8:29

GoogleCodeExporter commented 9 years ago
I'd need an image that triggers the problem to test with.

Also, did you set it to scale in both directions? There are options for that.

Original comment by paracel...@gmail.com on 26 Oct 2013 at 8:37

GoogleCodeExporter commented 9 years ago
I emailed you a photo that triggers it.  A few things I noticed:

1) You have to be in fullscreen mode
2) It seems that only images in portrait mode are handled incorrectly
3) I do have it to scale horizontally and vertically (all 4 options in "fitting 
options" are checked)

I hope this helps... Happy to see that there is new life for Xee as well!

Original comment by obij...@gmail.com on 26 Oct 2013 at 10:54

GoogleCodeExporter commented 9 years ago
Oh, I think I see what is happening, if you have it set to both stretch and 
shrink, it gets confused about which to do. I'll have to look into that.

Original comment by paracel...@gmail.com on 26 Oct 2013 at 10:57

GoogleCodeExporter commented 9 years ago
Actually, that is a hard question: If the image is taller than the screen, but 
also narrower than the screen, and you set it to both stretch and shrink, which 
one IS it that you want? Do you want it stretched to fill the screen or shrunk 
to fit?

Original comment by paracel...@gmail.com on 26 Oct 2013 at 11:00

GoogleCodeExporter commented 9 years ago
I want it to always fit to the screen.  Scale up or down depending on the size 
of the image, just fit to screen.  The older version did it well.

Honestly I think this is only happening for some images, but you obviously know 
better.

I appreciate you looking at this though...

Original comment by obij...@gmail.com on 26 Oct 2013 at 11:20

GoogleCodeExporter commented 9 years ago
I think I figured out the common thread in these images which are sized 
incorrectly.  My screen resolution is set to 1920 x 1200.

All the images which were not sized correctly were:
  - Full Screen
  - Width of 1200 pixels
  - Portrait Mode

It seems that when the program encounters an image with a WIDTH which matches 
the HEIGHT of the screen resolution, there is a bug.

Original comment by obij...@gmail.com on 28 Oct 2013 at 9:45

GoogleCodeExporter commented 9 years ago

Original comment by paracel...@gmail.com on 29 Oct 2013 at 9:09

GoogleCodeExporter commented 9 years ago
Ok, what on earth... I sat down to try and fix this now, but it's no longer 
happening for me! I knew it happened before when I tested. Very mysterious...

Original comment by paracel...@gmail.com on 12 Nov 2013 at 12:31

GoogleCodeExporter commented 9 years ago
Ok, I think I finally managed to get it triggered and in a different way, and 
worked through the resizing logic again to try to handle all possible cases 
correctly.

This is a real mess, so I am not 100% sure I got it right, but it should behave 
better now.

Original comment by paracel...@gmail.com on 12 Nov 2013 at 1:35