Closed GoogleCodeExporter closed 9 years ago
Thanks for submitting a patch. I will test this out at the very earliest
opportunity. This has to get done before we launch to the public, or else new
people won't get any play, and the rankings will not converge quickly enough.
Original comment by cameron.jp@gmail.com
on 9 Sep 2010 at 2:04
From my reading of the patch players with no games (includes new players
right?) are chosen as the first player before anyone that has at least one game.
Original comment by janzert
on 9 Sep 2010 at 5:56
That's the intent, yes. Players without games (eg newly uploaded bots) have
higher priority so they can get a game.
Original comment by jokeserver
on 9 Sep 2010 at 6:14
My comments:
the hardcoded -30 minutes should be moved to a #define so it's easier to find
(probably as a positive number, then call the function with -LOOKBACKTIME or
whatever).
Also, given the speed of the server I think it shoudl initially be set to a
couple of hours 120
Line 151/152 of the diff show the use of:
str(player_one["submission_id"])
whereas elsewhere it has been replaced with
str(player_one)
is that a bug, or am I not reading the diff correctly
Original comment by zap...@gmail.com
on 11 Sep 2010 at 11:33
Re: str(player_one)
You're right, I must have missed those lines. player_one was originally a row
from a table, with a column "submission_id". The patch changes player_one to be
the actual submission_id, so this is definitely an error.
Original comment by jokeserver
on 11 Sep 2010 at 11:40
Given the possibly high variability in the number of games that have been
played in the recent past, maybe it would be better to change the SQL to order
by the timestamp and set an actual limit on the number of games returned?
Original comment by janzert
on 12 Sep 2010 at 3:59
Thanks for coding this! I'll be adding the "play least recently played
submissions" on top of the other branch.
Original comment by danie...@gmail.com
on 16 Sep 2010 at 1:26
Original issue reported on code.google.com by
jokeserver
on 8 Sep 2010 at 7:05Attachments: