gcode-mirror / google-highly-open-participation-drupal

Automatically exported from code.google.com/p/google-highly-open-participation-drupal
0 stars 0 forks source link

Workflow-ng: send a mail to a role #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Workflow-ng is a rule-based event driven action evaluation system to
customize Drupal's built-in workflows in a very flexible way. Workflow-ng
is already able to send email to a user when certain actions and conditions
are met when browsing Drupal. Sending mail to all users of a specific role
may be useful to notify all website administrators about updates to their
site. It likely has unknown numbers of useful applications when used
alongside custom content created with CCK.

For this task, you need first to install and familiarize yourself with the
Token and Workflow-ng modules for Drupal 5.5.

http://drupal.org/project/token
http://drupal.org/project/workflow_ng
http://drupal.org/node/156288

The objective is to create a new action listed in the System section named
"Send a mail to a role". The action should perform in relatively equivalent
manner to the "Send a mail to a user" action with the exception that it
will send the mail to all users in a selected role from a select box.

You will need to:
1. Read more about workflow-ng: http://drupal.org/node/156282
2. Familiarize yourself with writing actions and conditions:
http://drupal.org/node/156754
3. Use existing Drupal API functions where appropriate. Examples:
    user_roles(): http://api.drupal.org/api/function/user_roles/5
    drupal_mail(): http://api.drupal.org/api/function/drupal_mail/5
4. Write a patch against the DRUPAL-5 branch of CVS for workflow-ng that
supports mailing roles as a new action. Upload the patch to
http://drupal.org/node/200932.

The task is complete when fago (http://drupal.org/user/16747) marks the
patch ready to be committed at http://drupal.org/node/200932 or commits the
patch to CVS. Don't forget to copy the patch to this issue on code.google.com.

Contacts: fago (http://drupal.org/user/16747) and deekayen
(http://drupal.org/user/972)

Original issue reported on code.google.com by deeka...@deekayen.net on 14 Dec 2007 at 2:35

GoogleCodeExporter commented 9 years ago
I claim this task

Original comment by cwgord...@cwgordon.com on 17 Dec 2007 at 4:08

GoogleCodeExporter commented 9 years ago
Great! it's yours

Original comment by deeka...@deekayen.net on 17 Dec 2007 at 4:36

GoogleCodeExporter commented 9 years ago

Original comment by acli...@gmail.com on 17 Dec 2007 at 4:41

GoogleCodeExporter commented 9 years ago
Please wait until you're finished with issue 71, then you may claim this task.

Original comment by deeka...@deekayen.net on 17 Dec 2007 at 5:23

GoogleCodeExporter commented 9 years ago

Original comment by deeka...@deekayen.net on 17 Dec 2007 at 5:23

GoogleCodeExporter commented 9 years ago
I claim this task (again).

Original comment by cwgord...@cwgordon.com on 17 Dec 2007 at 10:34

GoogleCodeExporter commented 9 years ago
Ok cwgord, it's yours.

Original comment by acli...@gmail.com on 17 Dec 2007 at 10:35

GoogleCodeExporter commented 9 years ago
Patch attached. Needs review.

Original comment by cwgord...@cwgordon.com on 18 Dec 2007 at 1:44

Attachments:

GoogleCodeExporter commented 9 years ago
Holy cow that was fast!

Original comment by addi.be...@gmail.com on 18 Dec 2007 at 1:57

GoogleCodeExporter commented 9 years ago
Please look at the review at http://drupal.org/node/200932

Original comment by nup...@gmail.com on 18 Dec 2007 at 1:12

GoogleCodeExporter commented 9 years ago

Original comment by nup...@gmail.com on 18 Dec 2007 at 1:14

GoogleCodeExporter commented 9 years ago
Patch rerolled. Needs review again.

Original comment by cwgord...@cwgordon.com on 18 Dec 2007 at 8:54

Attachments:

GoogleCodeExporter commented 9 years ago
This is really at NeedsReview ;)

Original comment by addi.be...@gmail.com on 18 Dec 2007 at 9:04

GoogleCodeExporter commented 9 years ago
http://drupal.org/node/200932#comment-664466

Original comment by nup...@gmail.com on 19 Dec 2007 at 11:47

GoogleCodeExporter commented 9 years ago
@nuppla:  I know this is not written down anywhere but we have been keeping the
Google issue status at NeedsReview once it's set there, even after it's 
reviewed.  If
you're putting your reviews for this task on the drupal.org issue (which you 
are, and
that's what we want to happen), there's no need to note that on the google 
tracker
and/or change the status.  That's just too much to keep in sync.  Just handle 
the
review on d.o and once the task is completed you can come back here to mark the 
issue
closed.

When we see the status is NeedsReview we know the student has done work on the 
task
and probably hasn't abandoned it.

Original comment by acli...@gmail.com on 19 Dec 2007 at 12:12

GoogleCodeExporter commented 9 years ago
I like steady needs review for a different reason - once a patch is submitted, 
more
eyeballs helps find bugs others might not have seen.

Original comment by deeka...@deekayen.net on 19 Dec 2007 at 2:22

GoogleCodeExporter commented 9 years ago
ok

Original comment by nup...@gmail.com on 20 Dec 2007 at 11:07

GoogleCodeExporter commented 9 years ago
This is finished, final work attached.

Original comment by cwgord...@cwgordon.com on 21 Dec 2007 at 1:14

Attachments:

GoogleCodeExporter commented 9 years ago
Woohoo! Another task completed.

Original comment by addi.be...@gmail.com on 21 Dec 2007 at 1:19

GoogleCodeExporter commented 9 years ago

Original comment by acli...@gmail.com on 21 Jan 2008 at 3:58