Closed GoogleCodeExporter closed 9 years ago
I claim this task
Original comment by cwgord...@cwgordon.com
on 17 Dec 2007 at 4:08
Great! it's yours
Original comment by deeka...@deekayen.net
on 17 Dec 2007 at 4:36
Original comment by acli...@gmail.com
on 17 Dec 2007 at 4:41
Please wait until you're finished with issue 71, then you may claim this task.
Original comment by deeka...@deekayen.net
on 17 Dec 2007 at 5:23
Original comment by deeka...@deekayen.net
on 17 Dec 2007 at 5:23
I claim this task (again).
Original comment by cwgord...@cwgordon.com
on 17 Dec 2007 at 10:34
Ok cwgord, it's yours.
Original comment by acli...@gmail.com
on 17 Dec 2007 at 10:35
Patch attached. Needs review.
Original comment by cwgord...@cwgordon.com
on 18 Dec 2007 at 1:44
Attachments:
Holy cow that was fast!
Original comment by addi.be...@gmail.com
on 18 Dec 2007 at 1:57
Please look at the review at http://drupal.org/node/200932
Original comment by nup...@gmail.com
on 18 Dec 2007 at 1:12
Original comment by nup...@gmail.com
on 18 Dec 2007 at 1:14
Patch rerolled. Needs review again.
Original comment by cwgord...@cwgordon.com
on 18 Dec 2007 at 8:54
Attachments:
This is really at NeedsReview ;)
Original comment by addi.be...@gmail.com
on 18 Dec 2007 at 9:04
http://drupal.org/node/200932#comment-664466
Original comment by nup...@gmail.com
on 19 Dec 2007 at 11:47
@nuppla: I know this is not written down anywhere but we have been keeping the
Google issue status at NeedsReview once it's set there, even after it's
reviewed. If
you're putting your reviews for this task on the drupal.org issue (which you
are, and
that's what we want to happen), there's no need to note that on the google
tracker
and/or change the status. That's just too much to keep in sync. Just handle
the
review on d.o and once the task is completed you can come back here to mark the
issue
closed.
When we see the status is NeedsReview we know the student has done work on the
task
and probably hasn't abandoned it.
Original comment by acli...@gmail.com
on 19 Dec 2007 at 12:12
I like steady needs review for a different reason - once a patch is submitted,
more
eyeballs helps find bugs others might not have seen.
Original comment by deeka...@deekayen.net
on 19 Dec 2007 at 2:22
ok
Original comment by nup...@gmail.com
on 20 Dec 2007 at 11:07
This is finished, final work attached.
Original comment by cwgord...@cwgordon.com
on 21 Dec 2007 at 1:14
Attachments:
Woohoo! Another task completed.
Original comment by addi.be...@gmail.com
on 21 Dec 2007 at 1:19
Original comment by acli...@gmail.com
on 21 Jan 2008 at 3:58
Original issue reported on code.google.com by
deeka...@deekayen.net
on 14 Dec 2007 at 2:35