Write hook_uninstall for several Drupal modules

[GoogleCodeExporter]

Task Description:

Check that all of the listed modules below have .install files, that they
have a hook_uninstall. and that the hook_uninstall deletes all tables and
variables (using variable_del). It should delete any tables that are
created in hook_install. And it should delete any variables that are
created. Variables are usually created through the call to variable_set,
but they can also be created through the settings forms (look for the
function that defines system_settings_form).

You don't need a local sandbox, but having one would be best. It's always
best to run the code before submitting a patch. But since this is a fairly
repetitive task, and in most cases you'll be creating a new .install file,
the local sandbox isn't a "hard" requirement.

A sample hook_uninstall, taken from phpass, is:

function phpass_uninstall() {
  db_query("DROP TABLE {user_phpass}");
  variable_del('user_hash_method');
  variable_del('user_hash_strength');
  variable_del('user_hash_portable');
}

Before you start on any one module, you should check the modules issue
queue to make sure that a patch hasn't been submitted. Please add a comment
to this issue when you complete a module. I'll also try to check them off
in the module description, as the issues are marked RTBC or Fixed.

Task 1:

   1. CiviCRM Active User
   2. CiviCRM Count Block
   3. CiviCRM Theme
   4. Coder
   5. Short Form

Coder is the only big module in Task 1. You'll need to look at
_coder_settings_form(). Three of the modules are related to CiviCRM. You
don't absolutely need CiviCRM to complete this task, but learning about
CiviCRM would be a good thing.

Deliverables:

    * create a Drupal issue against each module and submit a patch file for
5.x. If there is already a .install file, then be sure to submit the patch
against the latest version on the DRUPAL-5 or DRUPAL-5--2 branches. You'll
need to know how to create a patch file that adds a new file. The
deliverable is not complete until the issue is reviewed and the status is
set to either RTBC or Fixed (i.e., committed).
    * If a module is up-to-date and doesn't need a patch file, add a
comment to this issue, saying that you checked the module and that it
doesn't need to be patched.

Resources:

    * api.drupal.org: hook_uninstall, variable_del, system_settings_form
    * Patch files and Creating patches
    * General GHOP Resources

Primary Contact: Doug Green

Original issue reported on code.google.com by acli...@gmail.com on 17 Jan 2008 at 4:00

[GoogleCodeExporter]

Original comment by acli...@gmail.com on 17 Jan 2008 at 4:01

• Changed state: Open

[GoogleCodeExporter]

Fixing DrupalIssue tag.

Original comment by acli...@gmail.com on 17 Jan 2008 at 4:06

• Added labels: DrupalIssue-211174
• Removed labels: DrupalIssue-211175

[GoogleCodeExporter]

Isn't this a duplicate of
http://code.google.com/p/google-highly-open-participation-drupal/issues/detail?i
d=156&colspec=ID%20Status%20Summary%20DueDate%20DrupalIssue%20ClaimedBy%20Modifi
ed
?

Original comment by edwardzy...@gmail.com on 19 Jan 2008 at 8:03

[GoogleCodeExporter]

I claim this task.

Original comment by kou...@gmail.com on 19 Jan 2008 at 11:11

[GoogleCodeExporter]

Ok, it's yours kourge

Original comment by acli...@gmail.com on 19 Jan 2008 at 11:14

• Changed state: Claimed
• Added labels: ClaimedBy-kourge, DueDate-2008-01-27

[GoogleCodeExporter]

Status update: http://drupal.org/node/211174#comment-698313

Original comment by kou...@gmail.com on 20 Jan 2008 at 8:11

[GoogleCodeExporter]

Marking as needs review.

Original comment by acli...@gmail.com on 20 Jan 2008 at 3:00

• Changed state: NeedsReview

[GoogleCodeExporter]

Here is a zipped up copy of all the individual patches.

Original comment by kou...@gmail.com on 21 Jan 2008 at 4:27

Attachments:

• hook_uninstall_patches.zip

[GoogleCodeExporter]

Ok, reviewed all of them

Original comment by dmitri...@gmail.com on 21 Jan 2008 at 4:28

• Changed state: Closed

[GoogleCodeExporter]

Original comment by acli...@gmail.com on 21 Jan 2008 at 4:08

• Added labels: AdminChecked