Write hook_uninstall for several Drupal modules

[GoogleCodeExporter]

Task Description:

Check that all of the listed modules below have .install files, that they
have a hook_uninstall. and that the hook_uninstall deletes all tables and
variables (using variable_del). It should delete any tables that are
created in hook_install. And it should delete any variables that are
created. Variables are usually created through the call to variable_set,
but they can also be created through the settings forms (look for the
function that defines system_settings_form).

You don't need a local sandbox, but having one would be best. It's always
best to run the code before submitting a patch. But since this is a fairly
repetitive task, and in most cases you'll be creating a new .install file,
the local sandbox isn't a "hard" requirement.

A sample hook_uninstall, taken from phpass, is:

function phpass_uninstall() {
  db_query("DROP TABLE {user_phpass}");
  variable_del('user_hash_method');
  variable_del('user_hash_strength');
  variable_del('user_hash_portable');
}

Before you start on any one module, you should check the modules issue
queue to make sure that a patch hasn't been submitted. Please add a comment
to this issue when you complete a module. I'll also try to check them off
in the module description, as the issues are marked RTBC or Fixed.

Task 2:

   1. Reindex
   2. Retease
   3. Views Date Range Filter
   4. Views Fast Search
   5. Views Filter Block
   6. Views Tagadelic

Reindex is a 6.x module, so the patch should be against 6.x. All the other
modules, except Retease, are related to the Views module. You don't need to
install Views to complete this task, but once again, learning about Views
would be a good thing.

Deliverables:

    * create a Drupal issue against each module and submit a patch file for
5.x. If there is already a .install file, then be sure to submit the patch
against the latest version on the DRUPAL-5 or DRUPAL-5--2 branches. You'll
need to know how to create a patch file that adds a new file. The
deliverable is not complete until the issue is reviewed and the status is
set to either RTBC or Fixed (i.e., committed).
    * If a module is up-to-date and doesn't need a patch file, add a
comment to this issue, saying that you checked the module and that it
doesn't need to be patched.

Resources:

    * api.drupal.org: hook_uninstall, variable_del, system_settings_form
    * Patch files and Creating patches
    * General GHOP Resources

Primary Contact: Doug Green

Original issue reported on code.google.com by acli...@gmail.com on 17 Jan 2008 at 4:05

[GoogleCodeExporter]

I claim this task.

Original comment by cor...@gmail.com on 19 Jan 2008 at 3:23

[GoogleCodeExporter]

Ok corsix, it's yours.  I'm starting my stopwatch :)

Original comment by acli...@gmail.com on 19 Jan 2008 at 3:35

• Changed state: Claimed
• Added labels: ClaimedBy-corsix, DueDate-2008-01-26

[GoogleCodeExporter]

Stop that stopwatch ;)

Original comment by cor...@gmail.com on 19 Jan 2008 at 4:31

[GoogleCodeExporter]

Stopwatch stopped.  Marking needs review.

Original comment by acli...@gmail.com on 19 Jan 2008 at 4:38

• Changed state: NeedsReview

[GoogleCodeExporter]

Not everything has been written (sorry)

Original comment by dmitri...@gmail.com on 21 Jan 2008 at 4:51

• Changed state: Claimed

[GoogleCodeExporter]

What do you mean by that?

views_filterblock: http://drupal.org/node/211943
views_fastsearch: http://drupal.org/node/211952
retease: http://drupal.org/node/211948
reindex / daterange / tagadelic: Don't need a hook_uninstall

Original comment by cor...@gmail.com on 21 Jan 2008 at 7:48

[GoogleCodeExporter]

All of the relevant issues are either fixed or set to needs review, so I'm 
setting
this back to needs review as well.

Original comment by acli...@gmail.com on 21 Jan 2008 at 1:33

• Changed state: NeedsReview

[GoogleCodeExporter]

I'm sorry, I'll review right now

Original comment by dmitri...@gmail.com on 21 Jan 2008 at 3:05

[GoogleCodeExporter]

d.o task marked fixed by dmitrig01; attaching patch files.

Original comment by cor...@gmail.com on 21 Jan 2008 at 4:57

Attachments:

• views_fastsearch_uninstall_4b.patch
• views_filterblock_uninstall.patch
• retease_uninstall.patch

[GoogleCodeExporter]

Original comment by acli...@gmail.com on 21 Jan 2008 at 4:59

• Changed state: Closed

[GoogleCodeExporter]

Original comment by acli...@gmail.com on 21 Jan 2008 at 5:00

• Added labels: AdminChecked