gcode-mirror / google-highly-open-participation-drupal

Automatically exported from code.google.com/p/google-highly-open-participation-drupal
0 stars 0 forks source link

Write an "Execute arbitrary PHP-Code" action and condition for worklfow-ng module #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Issue: http://drupal.org/node/179917
Goal: Create a patch, which adds this functionality to workflow-ng. It
should be possible to make use of all available arguments in the PHP Code.
Also add token integration, which is no big deal with workflow-ng's token
helpers. Provide an action that allows executing arbitrary code as well as
a PHP enabled condition (returns TRUE/FALSE).

   1. Read more about workflow-ng: http://drupal.org/node/156282
   2. Read more about how to write actions and conditions:
http://drupal.org/node/156754
   3. Study the code of workflow-ng's token helpers, which you can find at
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/workflow_ng/workflo
w_ng/modules/workflow_ng_token.inc?revision=1.1.2.8&view=markup&pathrev=DRUPAL-5
      This is interesting for you, because the token integration makes use
of all available arguments, like it should be possible for the written php
code.
   4. Solve it like the token integration. Scan the code for all used
arguments and make these arguments available to the PHP code on action
execution time. This is necessary to ensure that only needed arguments get
loaded. Be sure that tokens are replaced before the PHP code is evaluated.
   5. Add the condition and action as provided by the module "workflow-ng"
itself, so add the code in the existing file
modules/workflow_ng_workflow_ng.inc. Use eval() for executing the code.
First start with the action. Once the action is in place, the condition is
done easily.

Primary contact: fago

Estimated time: 5 days

Drupal issue: http://drupal.org/node/179917

Original issue reported on code.google.com by webchick...@gmail.com on 7 Dec 2007 at 5:07

GoogleCodeExporter commented 9 years ago
I claim this task.

Original comment by cor...@gmail.com on 10 Dec 2007 at 11:15

GoogleCodeExporter commented 9 years ago
Ok corsix, it's all yours.

Original comment by acli...@gmail.com on 10 Dec 2007 at 11:16

GoogleCodeExporter commented 9 years ago
Wow, this actually went for review and has been committed by the maintainer!
http://drupal.org/node/179917

Corsix, please upload your last patch here and we can call this closed.  
Awesome job!

Original comment by addi.be...@gmail.com on 12 Dec 2007 at 5:32

GoogleCodeExporter commented 9 years ago
Mirroring final patch here, as per section 12 of the rules ("All Entries (code 
and
otherwise) must be submitted and published on the Project Hosting site as 
specified
in Section 6, a publicly accessible location on the Google Code site.")

Original comment by cor...@gmail.com on 12 Dec 2007 at 5:32

Attachments:

GoogleCodeExporter commented 9 years ago
Awesome! Go get another task!

Original comment by addi.be...@gmail.com on 12 Dec 2007 at 5:37

GoogleCodeExporter commented 9 years ago

Original comment by acli...@gmail.com on 21 Jan 2008 at 3:55