Some SysAllocator replacements do not work with memory decommiting on windows (was: system-alloc_unittest tests fail in MSVC2013 under Win8.1 x64)

gcode-mirror / gperftools

Automatically exported from code.google.com/p/gperftools

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Some SysAllocator replacements do not work with memory decommiting on windows (was: system-alloc_unittest tests fail in MSVC2013 under Win8.1 x64) #665

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Using the latest release of v2.4 I got the following errors running the tests 
compiled in MSVC2013-Upd4 under Windows 8.1-64bit:

C:\Google\gperftools-2.4\x64\Debug>addr2line-pdb.exe
SymLoadModuleEx returned error : 6 for a.out

C:\Google\gperftools-2.4\x64\Debug>system-alloc_unittest.exe
Assertion failed: success == TRUE, file ..\..\src\windows\system-alloc.cc, line 
166
(-> And then the whole shell froze and had to be killed)

Original issue reported on code.google.com by patle...@gmail.com on 14 Jan 2015 at 10:30

GoogleCodeExporter commented 9 years ago

add2line-pdf.exe is not a test.

But system-alloc_unittest is indeed failing.

This is bug in our handling of custom SysAllocator instances and releasing 
memory back to OS on windows.

You can largely ignore this unless you're need to deal with custom SysAllocator.

Original comment by alkondratenko on 18 Jan 2015 at 2:28

GoogleCodeExporter commented 9 years ago

Updating ticket title.

So assertion fails because test's SysAllocator returns memory that is backed by 
array. For that memory MEM_DECOMMIT doesn't work which causes assertion.

Original comment by alkondratenko on 18 Jan 2015 at 2:51

Changed title: Some SysAllocator replacements do not work with memory decommiting on windows (was: system-alloc_unittest tests fail in MSVC2013 under Win8.1 x64)

GoogleCodeExporter commented 9 years ago

Issue 681 has been merged into this issue.

Original comment by alkondratenko on 15 Apr 2015 at 3:03