Potential memory leak in HeapProfileTable::FillOrderedProfile

gcode-mirror / gperftools

Automatically exported from code.google.com/p/gperftools

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Potential memory leak in HeapProfileTable::FillOrderedProfile #699

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

In HeapProfileTable::FillOrderedProfile 
(https://code.google.com/p/gperftools/source/browse/src/heap-profile-table.cc#34
2) list is not dealloced if the function returns early (from line 353 or 364). 
This will probably never happen, but it still might be worth fixing.

Original issue reported on code.google.com by theycall...@gmail.com on 17 Jul 2015 at 8:34

GoogleCodeExporter commented 9 years ago

Thanks. Good catch. Should I expect patch for that ?

Original comment by alkondratenko on 25 Jul 2015 at 5:24

GoogleCodeExporter commented 9 years ago

Here is a patch, but I haven't tested it.

Original comment by theycall...@gmail.com on 27 Jul 2015 at 6:37

Attachments:

0001-issue-699-Free-list-on-error-paths.patch

GoogleCodeExporter commented 9 years ago

Applied. Thanks a lot.

Original comment by alkondratenko on 1 Aug 2015 at 7:39

Changed state: Done