search

gcollazo / BrowserRefresh-Sublime

This plugin will switch from ST2 and ST3 to Google Chrome, Google Chrome Canary, Safari, Firefox or Opera and reload the active tab
http://gcollazo.github.com/BrowserRefresh-Sublime
565 stars 62 forks source link

Setting `activate_browser` to false doesn't work #17

Closed adamkiss closed 11 years ago

adamkiss commented 11 years ago

Hello, first of all, thanks for this plugin.

Steps

Create user settings with:

[
    {
        "keys": ["command+shift+r"], "command": "browser_refresh", "args": {
            "auto_save": true,
            "delay": 0.0,
            "activate_browser": false,
            "browser_name" : "Google Chrome"
        }
    }
]

Expected result

Google chrome refreshes, Sublime Text stays active.

Real result

Nothing happens (visible), but the refresh fails. Output from console:

Traceback (most recent call last):
  File "./sublime_plugin.py", line 356, in run_
  File "./BrowserRefresh.py", line 67, in run
    refresher.chrome()
  File "--snip--/mac/__init__.py", line 18, in chrome
    """.format(activate=self.activate)
AttributeError: MacBrowserRefresh instance has no attribute 'activate'

Thank you

nlenkowski commented 11 years ago

Agreed, thanks a ton for this plugin! It's very handy. Also, I'll second the bug report. Everything works fine until I set activate_browser to false. I'm on OSX 10.8.2 using latest builds of Sublime and the refresh plugin. I've tried getting this to work with just a single browser and with "all" browsers. Thanks in advance for looking into it.

gcollazo commented 11 years ago

I will look into it later today. Thanks for the report

nlenkowski commented 11 years ago

No problem. Thanks for the plugin.

Nathan Lenkowski littlebiglab.com (http://littlebiglab.com/)

On Monday, October 15, 2012 at 5:18 PM, Giovanni Collazo wrote:

I will look into it later today. Thanks for the report

— Reply to this email directly or view it on GitHub (https://github.com/gcollazo/BrowserRefresh-Sublime/issues/17#issuecomment-9448730).