search

gcollazo / BrowserRefresh-Sublime

This plugin will switch from ST2 and ST3 to Google Chrome, Google Chrome Canary, Safari, Firefox or Opera and reload the active tab
http://gcollazo.github.com/BrowserRefresh-Sublime
565 stars 62 forks source link

Chrome refresh not working on Windows - fixed. #44

Closed leafbird closed 10 years ago

leafbird commented 10 years ago

I'm using sublime text 2 on Windows 7 with Google Chrome. But package BrowserRefresh is not working. So I read code related with this point and I found wrong string argument to find Chrome browser (maybe chrome's process title changed some time ago).

tablatronix commented 10 years ago

Stil not working for me. What version of chrome did you test on ?

Version 31.0.1650.63 m here

I am unfamiliar with python, I am trying to figure out how to dump the handles from findwindows to see what all is finding.

tablatronix commented 10 years ago

nm, changed it back to - Google Chrome and it works again.

Guess it is not the same process title for some reason.

leafbird commented 10 years ago

Oh, I'm using same version of Chrome. I found the diffrence from Chrome's Language setting. I'm living in Korea, so my Language Setting is Korean. I read your comment and test my Chrome's Language setting as English. Then process title string's last part changed from '- Chrome' to '- Google Chrome'. I'll try re-change my modification again. New version will be find both '- Chrome' and '- Google Chrome' strings. I'm sorry for all English users.

leafbird commented 10 years ago

I changed again and request to merge it. See #45. Thanks.