petitlapin
commented
8 years ago Hi,
as discussed in irc, instead of having a new activity, you can inherit from drawnumber activity (like the clickanddraw activity). Changing the bool 'clickanddrawflag' with a string that will have 3 possible values depending on which activity you are: "clickanddraw", "drawnumber", "drawletter". Then, handle it in the js file to play the sound if you are in your mode (don't break the existing activities :)).
For the dots, I would put a higher z to the next items to select (I mean, if you have 1, 2, 3 that overrides, we should have the 1 in top, then the 2 then the 3).
I would put this activity in reading section (in ActivityInfo.qml).
if you resize the screen, the text is behind the bar and truncated (I'm not even sure the text is needed).
For the dots, I would put a higher z to the next items to select (for the A for example, the 19 hides the 2 but 2 would be the next one to select).
Thanks for your PR.
Johnny
Modified the "DrawLetters" Activity with following changes :- 1.) Changed name to drawletters instead of nitish_drawletters. 2.) Added sound of letters at start & at end. 3.) Added sound when the dots are clicked. 4.) Added some color to the next dot to be clicked. 5.) Changed the images of each level. 6.) Added some more levels. 7.) Added instruction at bottom of each level.
Waiting for reviews & suggestions.