search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
225 stars 169 forks source link

Finishing Drawletters #150

Closed Nitish18 closed 8 years ago

Nitish18 commented 8 years ago

Made the final changes as told to me. Waiting for reviews & suggestions. Thanks.

petitlapin commented 8 years ago

Hi,

you forgot to remove the images and the ogg (maybe .wav?) in drawnumber. Also, you commited Drawnumber.qml~ (temporary file ;)). Except this, it is good for me.

What would be interesting as future improvement (not for this PR), would be to reduce the size of the images: we'd have one background image and the second would only be what we add (for example, for A letter, the background would be A2.svg and the other image would only contain the 'A'). It should reduce the size by almost 2. Johnny