search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
219 stars 168 forks source link

New Morse Code Activity #162

Closed soura97 closed 7 years ago

soura97 commented 7 years ago

Please give some feedbacks :)

soura97 commented 7 years ago

I will later add a Welcome page which tells about morse code - it's history , usage etc briefly. This is the main structure of the activity.

soura97 commented 7 years ago

"At level 3, I had to type O in morse. I typed --- in keyboard but nothing happened." "after testing on phone/tablet, I still can't go to next sublevel when I put the correct answer."

I can't replicate this problem when I'm running from Qt Creator. I am able to go to next sublevels when I put the correct answer. Can you provide more information about this problem? Like, is the activity getting hanged and not responding after you type in the correct answer?

petitlapin commented 7 years ago

I get these errors (probably what I explained above with the loop): qrc:/gcompris/src/activities/morse_code/Morse_code.qml:273: qrc:/gcompris/src/activities/morse_code/Morse_code.qml:283: QString::arg: Argument missing: undefined, E qrc:/gcompris/src/activities/morse_code/Morse_code.qml:410: RangeError: Maximum call stack size exceeded. qrc:/gcompris/src/activities/morse_code/Morse_code.qml:273: qrc:/gcompris/src/activities/morse_code/Morse_code.qml:283: QString::arg: Argument missing: undefined, A qrc:/gcompris/src/activities/morse_code/Morse_code.qml:410: RangeError: Maximum call stack size exceeded. qrc:/gcompris/src/activities/morse_code/Morse_code.qml:273: qrc:/gcompris/src/activities/morse_code/Morse_code.qml:283: QString::arg: Argument missing: undefined, R qrc:/gcompris/src/activities/morse_code/Morse_code.qml:410: RangeError: Maximum call stack size exceeded. (this is what I get after typing '.', '-', '.', the first errors are for '.' (A), the second for '.-' (E), the last '.-.' for (R) which is the expected answer. Also, the Alphabet/Numeric value is not displayed (probably due to the error)

soura97 commented 7 years ago

Please check if this solves the problem of going to next sublevels. I'm working on the MorseMap instead of images.

petitlapin commented 7 years ago

It works now.

soura97 commented 7 years ago

I was stuck in school assignments for a couple of days. Please let me know if these changes are appropriate and if anything more needs to be done.

soura97 commented 7 years ago

I thought about adding the audio feature but when run from Qt creator, I'm not able to play any audio in GCompris activities. The error shown is - Error: "The autoaudiosink element is missing." Can you give me any idea how to fix this? I installed gstreamer-tools but no luck.

petitlapin commented 7 years ago

For wav, we don't play them on linux because of potential freeze with old gstreamer version. If you want to test, you can uncomment in src/core/GCAudio.qml the 2 times we do (don't push it in a PR): if(/.wav$/.test(file) && ApplicationInfo.platform == ApplicationInfo.Linux) return false

For the other issue, do you have gstreamer0.10-plugins-good installed?

soura97 commented 7 years ago

I installed gstreamer0.10-plugins-good and then compiled again, but this time the error shown is : "Configured audiosink audio-output-bin is not working."

petitlapin commented 7 years ago

Hi, have you tried the first link on google: https://encrypted.google.com/search?hl=en&q=Configured%20audiosink%20audio-output-bin%20is%20not%20working ? first post of http://www.guayadeque.org/index.php?p=/discussion/155/error-gstreamer-error-configured-audiosink-playbackbin-is-not-working-/p1

soura97 commented 7 years ago

I installed gstreamer0.10-alsa and it solved the problem. Thanks :)

soura97 commented 7 years ago

@petitlapin I added the MorseMap. Is this okay?

soura97 commented 7 years ago

I tried fixing the alignment issues when screen size is changed. Please check if this solves the problems. I updated the readme with image source and license.

petitlapin commented 7 years ago

Hi,

there are still text size issues: http://pasteboard.co/psigfUxEd.png and http://pasteboard.co/psk2GYMfk.png. There is a property Text.Fit that allows you to set the width/height of a text and the text size will adapt to fit in it (check other activities, it is used). You can check by yourself by leaving fullscreen mode (ctrl+F) and resizing the windows.

For the images license, do you have the exact link of the image (not just the website)? Johnny

soura97 commented 7 years ago

Extremely sorry for the long hiatus due to my final exams. Please take a look and let me know if the text size issues are now fixed. I would also like to say that I have no other commitments now that my exams are over and I would like to contribute to GCompris for a long time without any interruption. Thanks in advance! :)

soura97 commented 7 years ago

Please take a look when you have time and let me know what else needs to be fixed :)

Thanks.

rahulyadav170923 commented 7 years ago

@soura97 the activity works correctly and i did not encounter any errors but you should make some changes.

  1. the cursor should be in the middle and smaller then outer rectangle . Improve the UI like the rectangle for input is too big and you can align third rectangle on the inputs right. (experiment)
  2. the label below the cursor does not update when the text is empty.
  3. the text codes of numbers & letter are not well aligned (use flow or grid)
  4. same goes in the help/list provided i have provided screenshot from the android device.
  5. the activity icon does not fit in landscape mode. https://drive.google.com/open?id=0B25oBy2F8e4jaW10U2JuMUlxeTg
petitlapin commented 7 years ago

Hi, external feedback from Horia:

Johnny

soura97 commented 7 years ago

Thanks for the suggestions. I have started working on them. I'll commit as soon as possible :)

On Mon, Feb 6, 2017 at 5:40 PM, petitlapin notifications@github.com wrote:

Hi, external feedback from Horia:

  • I think the dot should be on the same line with the dash (·-, not .-). If it is down, our brain may perceive it like the end of a phrase.
  • for the sound mode, it could be nice to have a "free" mode, where the child could type what he wants and get the corresponding sound.

Johnny

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gcompris/GCompris-qt/pull/162#issuecomment-277663773, or mute the thread https://github.com/notifications/unsubscribe-auth/AIhulqyEWyQJOVi58m5BPusSKHVh1Cwlks5rZw3AgaJpZM4KXp3u .

--

Regards,

Souradeep Barua,

Computer Science and Engineering Department,

Jadavpur University, kolkata

soura97 commented 7 years ago

Hi, How would you like the "free mode" to be introduced? Should there be an option in the first page or should there be a different activity for that only? Or do you have something else in mind?

petitlapin commented 7 years ago

Hi, for now, I don't have any idea, but it's not important for now, you should first focus on the other issues nd once they are solved, we can move on creating the free mode

soura97 commented 7 years ago

I was trying to fix the letter-in-word activity and forgot to create a new branch, sorry for the mix-up. Also, please check the new morse-map whenever you have time. :)