Hangman attempted chars

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris

225 stars 169 forks source link

Closed RudraNilBasu closed 7 years ago

RudraNilBasu commented 7 years ago

Displays a list of characters attempted by the user.

checked with resizing the screen and enabling the image.
qsTr() is used for strings that are to be translated
All types of characters will be included in the list, and not just A-Z English characters. (Since whatever string comes to the processKeyPress(text) function as parameter is added to the list).

RudraNilBasu commented 7 years ago

@petitlapin thank you for the review. I have updated the PR. These problems should be fixed

the warning related to the anchors is sorted out
the layout is fixed, the text doesn't appear on top of the hints image. The text is placed on a Rectangle, to enhance the visibility
Characters in the text are sorted
Fixed translation issues in a language that displays in the other direction: "used letters: Attempted"

RudraNilBasu commented 7 years ago

@petitlapin Thank you for the review, I am away from keyboard for few days, will make the changes when I get back with it.

RudraNilBasu commented 7 years ago

@petitlapin updated the PR, the issues are solved in this commit.

petitlapin commented 7 years ago

merged in kde master branch, thank you!