gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
219 stars 168 forks source link

Categorization: Add another mode and audio at drop #190

Closed amitsagtani97 closed 7 years ago

amitsagtani97 commented 7 years ago

Link to Task Details

divyam3897 commented 7 years ago

You would probably need one more check box for the category image (one at top right) to handle it. We can probably also handle everything with the combinations of score and instructions and image and probably not even need the easy, medium and expert modes?

amitsagtani97 commented 7 years ago
divyam3897 commented 7 years ago

I haven't had a look at the code (I just tested it for now). Here are the issues to be fixed:

  1. Unchecking the intructions do not hide them.
  2. not always but I reproduced it many a times -> disable the instructions and enable the score and images, I didn't see any images
  3. The zone color changes still when image completely enters (it could be better if it changes when image just touches the zone, just enters).
  4. The options last checked/unchecked is not saved in config. (Chose an option, close categorization and then come back, I couldn't find the one I chose).
divyam3897 commented 7 years ago

Had the following issues:

  1. In medium mode and expert mode (the images overwrite the category image) : https://pasteboard.co/GCKTNWu.png
  2. In medium mode, if I exit the config it is in medium mode but if I return from a level it shows me I am ready button.
  3. The config saving is better but it still had some issues (not reproducible always).
  4. I got the following warnings:
    qrc:/gcompris/src/activities/categorization/Categorization.qml:171: Error: Cannot assign [undefined] to bool
    QFont::setPointSizeF: Point size <= 0 (0.000000), must be greater than 0
  5. I am not sure if there should be so many modes for expert (I see I am ready in various situations, may be in many cases it would not be required, probably we can keep them simple in those cases) It needs to be checked with everyone regarding what would be suitable :)
petitlapin commented 7 years ago

as discussed on irc