gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
219 stars 168 forks source link

Fixing bugs in backgroundMusic branch. #206

Closed gupta2140 closed 6 years ago

gupta2140 commented 6 years ago

Fixed a bug when music didn't play on restarting GCompris after shutting it down with Background music disabled.

gupta2140 commented 6 years ago

The background music playlist repeats after all the music have been played.

gupta2140 commented 6 years ago

Corrected coding style of "if" statements. Waiting for review!

gupta2140 commented 6 years ago

Implemented pausing of background music and updated musical activities in which background music needs to be paused. Waiting for review!

gupta2140 commented 6 years ago

All the above requested changes have been made. Waiting for review! :)

gupta2140 commented 6 years ago

Above suggested improvements are made. Waiting for review!

gupta2140 commented 6 years ago

Committed here: https://cgit.kde.org/gcompris.git/commit/?h=backgroundMusic&id=f4ba64ed3594ad7073cbbc1fa3c596231240bf5f