ballcatch, Fix vertical mode layout [T7613]

darkHarry commented 6 years ago

This Pull Request does the following for the activity "Make the ball go to tux" in vertical mode:

makes the intro text to go on top removing the obstruction by hands (Ballcatch.qml).
move the arrow keys up and smaller removing the obstruction by hands (Ballcatch.qml).
make the ball smaller to make it look proportionate with vertical screen (Ball.qml).

To make the title visible properly core file was changed:

width of the title text (GCText) was reduced by subtracting the width of the cancel button (DialogBackGround.qml) and the width of the difficulty stars.
Intro text bubble was removed and IntroMessage Container was added.

petitlapin commented 6 years ago

Hi,

it's good for me, but I can't commit because you author name does not match the kde convention: "FirstName LastName ", yours is "dark_harry ". Do I put "Dark Harry" or "Harry M..."?

darkHarry commented 6 years ago

Hey! Thanks for reviewing. You can put "Harry Mecwan".

petitlapin commented 6 years ago

Committed in https://cgit.kde.org/gcompris.git/commit/?id=3736b443381ecb3546b2375d99e1ca16e3216572 (core feature) and https://cgit.kde.org/gcompris.git/commit/?id=fd7a2796a3814185f3bb3fa04ff8f3db56127ceb (ballcatch fix) Thank you!

gcompris / GCompris-qt

ballcatch, Fix vertical mode layout [T7613] #209