search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
219 stars 168 forks source link

Sound when winning - followline activity #228

Closed Boute95 closed 6 years ago

Boute95 commented 6 years ago

Plays a sound of water dropped on fire when winning in the followline activity.

petitlapin commented 6 years ago

Thank you, but there is already a sound played when it's won: https://github.com/gcompris/GCompris-qt/blob/master/src/activities/followline/Followline.qml#L135 and https://github.com/gcompris/GCompris-qt/blob/master/src/activities/followline/LinePart.qml#L63 Also, there is no license attached to your sound and a link from where it's taken from, it would have been needed.

Boute95 commented 6 years ago

Oh I'm really confused, I think I forgot to comment the code that disable wav sounds for Linux when playing the game and I missed it.

Also I didn't know I had to put the licence and the link for CC0, I only put the artist name in the metadata.

I'm sorry for my mistakes, next time I'll be more careful.

petitlapin commented 6 years ago

no problem, it's to give credit to the creator and be sure we are authorized to use the sounds/music (depending on the licence or if none is provided, w can't use it)