search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
227 stars 169 forks source link

Empty squares in "build the same model" with greek language #247

Closed spacevoyager78 closed 5 years ago

spacevoyager78 commented 5 years ago

In 0.95 and 0.96 when using "build the same model" with greek language I get empty squares. With english language I get english letters. Also, the arrow buttons and the crane appear distorted when the screen resolution is not wide (in my case 1280x1024). Version 0.91 doesn't have these issues (I get english letters with greek language and no distortion). Please see folllowing pictures:

0.96, greek language, 1280x1024 Build_the_same_model_0 96_1280x1024_greek

0.96, greek language, 1366x768 Build_the_same_model_0 96_1366x768_greek

0.91, greek language, 1280x1024 Build_the_same_model_0 91_1280x1024_greek

0.91, greek language, 1366x768 Build_the_same_model_0 91_1366x768_greek

petitlapin commented 5 years ago

Hi,

thank you for the report.

The error is because we translated the displayed words with non ascii letters: https://github.com/gcompris/GCompris-qt/blob/master/src/activities/crane/crane.js#L71 I'll contact the Greek person to know how to handle this (either we add new images for the Greek letters but it will be too much as we'll have to do it for other locales too or we keep them in English which is lighter for the final executable).

petitlapin commented 5 years ago

Fixed in https://phabricator.kde.org/R883:1539796 and https://phabricator.kde.org/R883:1539797 We won't plan a bug fix for now, it will be fixed in next release. The activity is playable for higher levels where we don't use specific translated words.

Thank you for the report