search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
226 stars 169 forks source link

Modifications to incorporate separate British and American English. #248

Closed joshreve closed 5 years ago

joshreve commented 5 years ago

Modifications to incorporate separate British and American English. Also, support for additional words covered by American English voice resources. See accompanying pull request in GCompris-data with added content. Modifications also made to allow proper loading of both en and en_GB when selected in the settings menu. Loading of both locales tested on Linux (Mint).

petitlapin commented 5 years ago

Hi, thank you! There are other specific files for UK English/American English (for example https://github.com/gcompris/GCompris-qt/blob/master/src/activities/wordsgame/resource/default-en.json) where some words will need to be changed in UK English (I spotted "color" and "license" for example that are not correct in UK English). I'll merge this PR and fix the other files once we have merged the other one and generated the audio files so people using GCompris in UK English will still have voices for now.

Johnny

joshreve commented 5 years ago

Sounds good. I will check the commits later to see what I missed in case I end up adding any content in the future.

Thanks,

Joshua Shreve

On Sat, Aug 31, 2019 at 12:12 PM Johnny Jazeix notifications@github.com wrote:

Hi, thank you! There are other specific files for UK English/American English (for example https://github.com/gcompris/GCompris-qt/blob/master/src/activities/wordsgame/resource/default-en.json) where some words will need to be changed in UK English (I spotted "color" and "license" for example that are not correct in UK English). I'll merge this PR and fix the other files once we have merged the other one and generated the audio files so people using GCompris in UK English will still have voices for now.

Johnny

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gcompris/GCompris-qt/pull/248?email_source=notifications&email_token=ABMSWGAIQ2JRZCO6UV6GSK3QHKJ5NA5CNFSM4ISTY3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TPX3A#issuecomment-526842860, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMSWGD6AV6ZY45YPS3VFZTQHKJ5NANCNFSM4ISTY3UA .

petitlapin commented 5 years ago

It's been merged for a while, closing the PR. Thank you!

joshreve commented 5 years ago

Do you have an approximate time frame for when this update will be setup for automatic download into the program? I have been periodically checking the data2 folder on the website where the program acquires the sound files from, but have not seen a recent update. I understand you may have other changes to roll in, but just wanted to get an ETA.

On Wed, Oct 23, 2019 at 6:35 AM Johnny Jazeix notifications@github.com wrote:

It's been merged for a while, closing the PR. Thank you!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gcompris/GCompris-qt/pull/248?email_source=notifications&email_token=ABMSWGHTX3YUWMXGE25LQBLQQASIHA5CNFSM4ISTY3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECA5SNA#issuecomment-545380660, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMSWGEJJ7GYKYJT3JJGDPTQQASIHANCNFSM4ISTY3UA .

petitlapin commented 5 years ago

Hi, the change will be done with the new version (we plan one for December). We will use a KDE server to store the data (https://cdn.kde.org/gcompris/data2/) where it is now stored. I'm not sure if it will work but if you are using GCompris on a Linux/MacOS (~/.config/gcompris/gcompris-qt.conf) or Windows (C:\Users\\AppData\Local\gcompris\GCompris.conf) platform, you can update the configuration file to point to this server (line "downloadServerUrl=https://cdn.kde.org/gcompris").

joshreve commented 5 years ago

Thanks for the update. I appreciate the instructions for setting it up to run with the updated voices and look forward to the new version.

On Mon, Oct 28, 2019 at 3:35 AM Johnny Jazeix notifications@github.com wrote:

Hi, the change will be done with the new version (we plan one for December). We will use a KDE server to store the data ( https://cdn.kde.org/gcompris/data2/) where it is now stored. If you are using GCompris on a Linux/MacOS (~/.config/gcompris/gcompris-qt.conf) or Windows (C:\Users\AppData\Local\gcompris\GCompris.conf) platform, you can update the configuration file to point to this server (line "downloadServerUrl=https://cdn.kde.org/gcompris"). For android, it's harder to find this configuration file :/.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gcompris/GCompris-qt/pull/248?email_source=notifications&email_token=ABMSWGHOGKH2ZY33GFANNUDQQ2I2NA5CNFSM4ISTY3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECL6NNI#issuecomment-546825909, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMSWGCCMV2S4O2HBBBIER3QQ2I2NANCNFSM4ISTY3UA .