solar system: improve hint system

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris

226 stars 169 forks source link

solar system: improve hint system #253

Closed anuj952 closed 4 years ago

anuj952 commented 4 years ago

I have worked on the task T12339 under the junior jobs .

Currently only 2 questions (temperature and revolution) have hints.
I have added an additional hint for the question of positions of planets . I thought providing a rhyme will help students to learn postions easily.
For other questions as the answers are too random so no hints are given , when hint button is clicked a DialogBackground is shown to tell there is no hint .

Please review this and tell me if any changes are required .

petitlapin commented 4 years ago

Hi Anuj,

this is not the way to do merge request, we have a wiki page explaining: https://gcompris.net/wiki/Contribution_process (basically https://phabricator.kde.org/differential/diff/create).

Also, if you plan to work on a task, assign it to yourself on phabricator. I'm closing this pull request, we'll do the review on the phabricator diff.

Thank you,

Johnny

anuj952 commented 4 years ago

sorry for the request , I will do it the correct way

anuj952 commented 4 years ago

Can you please tell me how to get a login account on phabricator to create a diff

On Wed, Mar 11, 2020 at 10:25 PM Johnny Jazeix notifications@github.com wrote:

Closed #253 https://github.com/gcompris/GCompris-qt/pull/253.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gcompris/GCompris-qt/pull/253#event-3119687204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDH35BZDPCXT62CWO677ZLRG667RANCNFSM4LFWCQ3Q .