search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
218 stars 167 forks source link

Exercise for New contributors #254

Closed moadmmh closed 4 years ago

moadmmh commented 4 years ago

I have just finished the given exercise for new contributors mentioned here

moadmmh commented 4 years ago

Okey i will keep all of the above comments in mind thank you again for your review

moadmmh commented 4 years ago

Hello i was just wondering if i take your comments in consideration for real commits or i have to modify the code for the contributor exercise and make another pull request ?

petitlapin commented 4 years ago

hi, only for real commits :), no need to update this PR