search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
218 stars 167 forks source link

Shutdown rocket anim after crash, allow explosion to roll #277

Closed kentavv closed 2 years ago

kentavv commented 2 years ago

Fixes: When rocket crashes the rocket burn would still appear after level reset (until OK was pressed.) Adds: An explosion rolls laterally the direction the rocket impacted.

petitlapin commented 2 years ago

thank you for the PR! I only have this question for the other maintainer, and if it's all good for him, I'll merge it after: @Animtim , does it make sense to have the explosion rolling when crashing?

kentavv commented 2 years ago

I didn't know what's better for young kids. It's slightly more physically correct and slightly more exciting, but the non-rolling explosion feels more ol' school arcade like. Best wishes

Animtim commented 2 years ago

Looks ok for me, thanks!

petitlapin commented 2 years ago

Thank you! It has been committed in https://invent.kde.org/education/gcompris/-/commit/398d933feabf42260fb3116bc873ed1416198ae5