Closed kentavv closed 2 years ago
thank you for the PR! I only have this question for the other maintainer, and if it's all good for him, I'll merge it after: @Animtim , does it make sense to have the explosion rolling when crashing?
I didn't know what's better for young kids. It's slightly more physically correct and slightly more exciting, but the non-rolling explosion feels more ol' school arcade like. Best wishes
Looks ok for me, thanks!
Thank you! It has been committed in https://invent.kde.org/education/gcompris/-/commit/398d933feabf42260fb3116bc873ed1416198ae5
Fixes: When rocket crashes the rocket burn would still appear after level reset (until OK was pressed.) Adds: An explosion rolls laterally the direction the rocket impacted.