search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
218 stars 167 forks source link

Update HACKING to change git to https and add webp dependency #291

Closed AlexTheAussieNerd closed 8 months ago

AlexTheAussieNerd commented 8 months ago

When installing from these directions i needed to make some changes.

I needed to use the command "git clone https://github.com/gcompris/GCompris-qt.git" instead of ".....git://...." otherwise the attempt would time out.

After building i noticed images in the Categorisation activity would not show thumbnail images for "Colours", "Animals" , "Food" etc. and clicking into Numbers would show the digits and letters (stored as .svg files) correctly, but other files (stored as .webp) were not shown. running the command "sudo apt install qt5-image-formats-plugins" and recompiling showed the previously invisible images.

AlexTheAussieNerd commented 8 months ago

Ive also just used the command line to clone my personal fork and couldnt reproduce with the text provided.

I did get a download started with 'git clone https://github.com/AlexTheAussieNerd/GCompris-qt.git" and request changing of the test in the existing HACKING be changed to "git clone https://github.com//GCompris-qt.git"

Edit: im happy to see about doing the change and modifying the pull request if that helps.

petitlapin commented 8 months ago

Hi, Thank you for the PR! This repository is just a mirror, the main development of GCompris is done in https://invent.kde.org/education/gcompris. If you plan to do more changes, it would be better to create an account, fork and do the updates in https://invent.kde.org/education/gcompris.

For this PR, I'll cherry-pick your commit directly and push it in a few hours in the main repository, it is good as it is.

petitlapin commented 8 months ago

We have rules in KDE that the author should be in the form "FirstName LastName ". In the commit, it is not the case, making the push failed.

Either I push with my name or if you want the credit (which is understandable as you did the job :)), can you please give me a compliant name for it? Note that the name will be written in GCompris credits directly in the application.

AlexTheAussieNerd commented 8 months ago

Thanks for the feedback and quick turn around. Cherry-picking is fine by me and i wasn't expecting to have everything included as-is, more initiating a broader look of the file to see if there were updates needed and show specific suggestions. Ive been part of a team where we developed some blindness to parts of the documentation as everyone just "knew" how to do things and issues weren't picked up until a fresh set of eyes looked on them.

I've used lots of KDE software before, notably KDEGames like Picmi and Knetwalk as well as a bit of KDevelop and for me the KDE stuff has a reputation for high quality.

I am aware that the KDE system is the main repository, but I'm highly reluctant to use my Firstname and Lastname. I'm very happy that anything done as part of this repository is rolled into the main one uncredited if the regular developers consider it worthwhile.

Pushing with your name is fine and if making changes here results in any changes being a lower priority for the dev team,

petitlapin commented 8 months ago

I've updated the list in https://invent.kde.org/education/gcompris/-/commit/6f6762ff10263a10532e9b1d5c298167d6fba962 with the list we have in the official wiki: https://gcompris.net/wiki/Qt_Quick_development_process#Compilation_prerequisites

Thanks again for pointing them out! It's ok to propose changes here for me and I'll commit in my name if you don't want to use yours, no problem either on my side.