search

gcompris / GCompris-qt

GCompris in Qt Quick - Mirror of https://invent.kde.org/education/gcompris
218 stars 167 forks source link

Update HACKING to include openssl dependency and correct command for … #292

Closed AlexTheAussieNerd closed 8 months ago

AlexTheAussieNerd commented 8 months ago

…forked repositories

I've re-run the install on a different machine and noted some more changes were needed.

No download would happen on the existing git clone command for forked repositories.

Building as per instructions failed on cmake? saying a dependeny wasn't met for openssl.

petitlapin commented 8 months ago

Thanks for testing and sorry for delay in answering,

libssl should not be required at compile time (it is an optional dependency at runtime if you need to download the assets) so cmake should not complain about it. Do you have the error?

AlexTheAussieNerd commented 8 months ago

I've just re-run and can confirm the error was reported after running "cmake .." (on a raspberry pi 400, latest 64bit os)

This isnt exactly the error message as I'm typing from another screen, but the numbers will be identical.

The source was downloaded from a git clone https:// official mirror repository

The following REQUIRED packages have been found:

Cmake Error at /usr/share/cmake-3.25/Modules/FeatureSummary.cmake:464 (message: feature_summary() Error: REQUIRED packages(s) are missiong, aborting CMake run. Call Stack (most recent call first): CMakeLists.txt:143 (feature_summary)

petitlapin commented 8 months ago

You're right (https://invent.kde.org/education/gcompris/-/blob/master/CMakeLists.txt#L132-135), I'll add the dependency in the README when I have 5 minutes. Thank you!

petitlapin commented 8 months ago

I've just pushed it in https://invent.kde.org/education/gcompris/-/commit/2b7989ab54c461efb49a55c4fc9de7286c99a07b.

Thank you!