search

gcorne / wp-react-boilerplate

Get started with using React in a WordPress plugin
129 stars 27 forks source link

Downgrade css-loader dependency for Node 0.10.x compatibility #3

Closed iandunn closed 8 years ago

iandunn commented 8 years ago

Running the build task under Node 0.10.x fails with the following error:

ERROR in ./~/css-loader!./~/sass-loader!./src/components/widget/style.scss Module build failed: ReferenceError: Promise is not defined

See webpack/css-loader#144 for details.

I think Node 0.10.x should be supported, because it's the latest version available in the Ubuntu package repository, so it's still widely used in dev environments.

Alternatively, though, the docs could just state that the project requires a current version of Node.

gcorne commented 8 years ago

Thanks for pointing this out. I decided to add an ES6 polyfill instead of downgrading in 62c122f.

iandunn commented 8 years ago

Ah, that's a better idea. Thanks :)